Skip to content

Address release PR issues#61

Open
chaochaowong wants to merge 6 commits into
nf-core:devfrom
chaochaowong:address-release-pr-issues
Open

Address release PR issues#61
chaochaowong wants to merge 6 commits into
nf-core:devfrom
chaochaowong:address-release-pr-issues

Conversation

@chaochaowong

Copy link
Copy Markdown

This PR address the release PR (#57) issues including (1) removing duplicated anonymous AWS S3 client setting and (2) fixing test profile reference configuration and test profile descriptions.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/pacvar branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@chaochaowong chaochaowong mentioned this pull request Jun 20, 2026
11 tasks
@chaochaowong chaochaowong requested a review from SPPearce June 20, 2026 23:14

@SPPearce SPPearce left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog as well.
Note that I'm on vacation for the next week so won't be very responsive.

@chaochaowong

Copy link
Copy Markdown
Author

Please update the changelog as well. Note that I'm on vacation for the next week so won't be very responsive.

Thank you for catching it. I updated the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants