Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/pr-tests.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,22 @@
name: PR Tests

on:
# Docs-only changes (Markdown anywhere + everything under docs/, incl.
# milestones.ics) don't touch the app, so skip the PHPUnit suite for them.
# The milestone-date invariant is covered by the local-only
# MilestoneScheduleConsistencyTest, not this gate.
push:
branches:
- codex/**
- feat/**
- feature/**
paths-ignore:
- '**/*.md'
- 'docs/**'
pull_request:
paths-ignore:
- '**/*.md'
- 'docs/**'
Comment on lines +17 to +19

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Do not skip the required PR workflow by path filter

For the protected/gated PR flow described in AGENTS.md, a docs-only PR now skips the entire PR Tests workflow instead of reporting a passing check. GitHub documents that when a workflow is skipped by path filtering, its checks remain Pending and PRs requiring them are blocked from merging (https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks), so a PR changing only README.md or docs/milestones.ics can deadlock rather than cheaply pass. Keep the pull_request workflow triggered and make the expensive test job conditional/no-op-success instead of filtering out the workflow.

Useful? React with 👍 / 👎.


jobs:
tests:
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
- If the user has uncommitted doc edits in the same active workstream, preserve them and include them in the next related commit by default unless the user says otherwise.
- Apply the UX guardrails in [`docs/UX_GUARDRAILS.md`](docs/UX_GUARDRAILS.md) on every UX touch: Nielsen/WCAG as baseline; inline guidance, preserved input, no layout shift, focus/error handling, mobile/accessibility.
- GitHub `main` is canonical and protected. New work branches follow `codex/<task>`, and existing PRs must be updated via their original source branch rather than alternate branches.
- PRs are gated by GitHub Actions `PR Tests`; keep branches current with `origin/main` before requesting review.
- PRs are gated by GitHub Actions `PR Tests`; keep branches current with `origin/main` before requesting review. Docs-only PRs (Markdown anywhere + `docs/**`, including `milestones.ics`) skip the suite via `paths-ignore`, so run milestone-date checks locally (the consistency test is local-only anyway).

## Multi-Agent Coordination
- Primary and secondary agents are role-based, not capability-limited: secondaries can work docs, code, tests, or modules within their stated task.
Expand Down
Loading