Skip to content

ci: skip PR Tests for docs-only changes#115

Merged
n8bar merged 1 commit into
mainfrom
claude/ci-skip-docs-tests
Jun 19, 2026
Merged

ci: skip PR Tests for docs-only changes#115
n8bar merged 1 commit into
mainfrom
claude/ci-skip-docs-tests

Conversation

@n8bar

@n8bar n8bar commented Jun 19, 2026

Copy link
Copy Markdown
Owner

The PR Tests workflow fired the full PHPUnit suite (MySQL + npm run build + migrate) on every PR, including markdown/docs-only edits that can't touch the app. Adds paths-ignore (**/*.md, docs/**) to both the push and pull_request triggers.

Why it's safe: main has no classic branch protection and no rulesets (verified via the API), so the tests check isn't a required status check — skipped runs still merge cleanly (no "waiting for required check" deadlock). The milestone-date invariant (PLAN.md Targets == milestones.ics) is guarded by the local-only MilestoneScheduleConsistencyTest, which this PR gate already excluded — so nothing is lost.

This PR touches the workflow itself, so CI runs here to validate; subsequent docs-only PRs will skip it.

🤖 Generated with Claude Code

The pr-tests workflow ran the full PHPUnit suite (MySQL + npm build +
migrate) on every PR, including markdown/docs-only changes — wasted
runner time on edits that can't affect the app. Add paths-ignore for
'**/*.md' and 'docs/**' on both triggers.

Safe: main has no branch protection or rulesets, so the tests check
gates nothing — skipped runs still merge. The milestone-date invariant
is guarded by the local-only MilestoneScheduleConsistencyTest, which
this gate never ran anyway.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@n8bar n8bar merged commit 11e7761 into main Jun 19, 2026
1 check passed
@n8bar n8bar deleted the claude/ci-skip-docs-tests branch June 19, 2026 23:56

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d30003518d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +17 to +19
paths-ignore:
- '**/*.md'
- 'docs/**'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Do not skip the required PR workflow by path filter

For the protected/gated PR flow described in AGENTS.md, a docs-only PR now skips the entire PR Tests workflow instead of reporting a passing check. GitHub documents that when a workflow is skipped by path filtering, its checks remain Pending and PRs requiring them are blocked from merging (https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks), so a PR changing only README.md or docs/milestones.ics can deadlock rather than cheaply pass. Keep the pull_request workflow triggered and make the expensive test job conditional/no-op-success instead of filtering out the workflow.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant