Skip to content

feat(iam): re-home audit-log-querier inheritance to activity service #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ecv wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −0
Draft

feat(iam): re-home audit-log-querier inheritance to activity service #677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23baecc
feat(iam): re-home audit-log-querier inheritance to activity service
ecv Jun 30, 2026
e9718a9
chore(iam): trim explanatory comment from audit-log-querier role
ecv Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions config/services/activity/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,8 @@
apiVersion: kustomize.config.k8s.io/v1alpha1
kind: Component

resources:
- roles/iam-user-self-manage-audit-log-querier.yaml

components:
- policies
9 changes: 9 additions & 0 deletions config/services/activity/roles/iam-user-self-manage-audit-log-querier.yaml
View file
Open in desktop

@scotwells scotwells Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this would do what you're expecting? This would create a new role called iam-user-self-manage, not patch the existing one.

Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# SPDX-License-Identifier: AGPL-3.0-only

apiVersion: iam.miloapis.com/v1alpha1
kind: Role
metadata:
name: iam-user-self-manage
spec:
inheritedRoles:
- name: activity.miloapis.com-audit-log-querier
Loading