feat(iam): re-home audit-log-querier inheritance to activity service#677
Draft
ecv wants to merge 2 commits into
Draft
feat(iam): re-home audit-log-querier inheritance to activity service#677ecv wants to merge 2 commits into
ecv wants to merge 2 commits into
Conversation
Move the iam-user-self-manage -> activity.miloapis.com-audit-log-querier role inheritance out of the foundational control-plane layer and into the activity service overlay (config/services/activity), which is only applied once the activity stack is present. The audit-log-querier Role is shipped by the activity service. Referencing it from the core role bundle forced the foundational milo control plane to depend on activity rolling out first -- an inverted dependency that pulled the foundation into datum-cloud/infra#2939. This adds a partial Role manifest that, under server-side apply, merges a single inheritedRoles entry into the iam-user-self-manage Role. inheritedRoles is a map-type list keyed by name, so the activity overlay owns just this entry while the core role bundle continues to own launchStage and includedPermissions. The core role bundle now has zero activity coupling. Refs: #676 Unblocks: datum-cloud/infra#2953 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
scotwells
requested changes
Jun 30, 2026
Contributor
There was a problem hiding this comment.
I don't think this would do what you're expecting? This would create a new role called iam-user-self-manage, not patch the existing one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #676.
Moves the
iam-user-self-manage→activity.miloapis.com-audit-log-querierrole inheritance out of the foundational control-plane layer and into the activity service overlay (config/services/activity), which is only applied once the activity stack is present. The core role bundle now has zero activity coupling.Why
The
activity.miloapis.com-audit-log-querierRole is shipped by the activity service. Referencing it from the core role bundle forced the foundational milo control plane to depend on activity rolling out first — an inverted dependency that pulled the foundation into datum-cloud/infra#2939.Changes
config/services/activity/roles/iam-user-self-manage-audit-log-querier.yaml— a partialRolemanifest that, under server-side apply, merges a singleinheritedRolesentry into theiam-user-self-manageRole.config/services/activity/kustomization.yaml— wires the new resource into the activity overlay.Validation
kustomize build config/services/activity→ rc=0; renders the mergedRolewith theactivity.miloapis.com-audit-log-querierinherited entry.kustomize build config/roles→ 0 references toaudit-log-querier(core layer is clean).Coordination