Mobt 1138 ignore git hash cli#2388
Merged
gavinevans merged 7 commits intoMay 28, 2026
Merged
Conversation
mo-kbogue
reviewed
May 22, 2026
| suppress_warnings: bool = False, | ||
| realization_collapse: bool = False, | ||
| subset_coord: str = None, | ||
| ignore_grid_match: bool = False, |
There was a problem hiding this comment.
Suggested change
| ignore_grid_match: bool = False, | |
| ignore_grid_match_check: bool = False, |
Just one option, this could also be called something like ignore_grid_mismatch. The current variable name could be misleading. Should be changed throughout CLI and plugins.
| suppress_warnings=suppress_warnings, | ||
| realization_collapse=realization_collapse, | ||
| subset_coord=subset_coord, | ||
| ignore_grid_match=ignore_grid_match, |
There was a problem hiding this comment.
Suggested change
| ignore_grid_match=ignore_grid_match, | |
| ignore_grid_match_check=ignore_grid_match_check, |
| self, | ||
| neighbour_selection_method: str = "nearest", | ||
| fixed_lapse_rate: float = None, | ||
| ignore_grid_match: bool = False, |
There was a problem hiding this comment.
Suggested change
| ignore_grid_match: bool = False, | |
| ignore_grid_match_check: bool = False, |
| plugin = SpotLapseRateAdjust( | ||
| neighbour_selection_method=self.neighbour_selection_method | ||
| neighbour_selection_method=self.neighbour_selection_method, | ||
| ignore_grid_match=self.ignore_grid_match, |
There was a problem hiding this comment.
Suggested change
| ignore_grid_match=self.ignore_grid_match, | |
| ignore_grid_match_check=self.ignore_grid_match_check, |
| plugin = SpotLapseRateAdjust( | ||
| neighbour_selection_method=self.neighbour_selection_method, | ||
| fixed_lapse_rate=self.fixed_lapse_rate, | ||
| ignore_grid_match=self.ignore_grid_match, |
There was a problem hiding this comment.
Suggested change
| ignore_grid_match=self.ignore_grid_match, | |
| ignore_grid_match_check=self.ignore_grid_match_check, |
| "neighbour_data", [np.array([[[0, 1, 2], [0, 1, 2], [0, 1, 2]]])] | ||
| ) | ||
| def test_ignore_grid_match_argument(neighbour_cube, apply_lapse_rate_correction): | ||
| """Test that when the ignore_grid_match argument is set to True, that the function |
There was a problem hiding this comment.
Suggested change
| """Test that when the ignore_grid_match argument is set to True, that the function | |
| """Test that when the ignore_grid_match_check argument is set to True, that the function |
Contributor
Author
|
The newest commit updates the docstrings and comments made during the review. |
brhooper
requested changes
May 26, 2026
Contributor
brhooper
left a comment
brhooper
left a comment
There was a problem hiding this comment.
Thanks @mo-jbeaver, I've just added a couple of comments suggesting some additional tests of the new option.
2 tasks
Kat-90
approved these changes
May 27, 2026
Contributor
Kat-90
left a comment
Kat-90
left a comment
There was a problem hiding this comment.
Ran the tests and checked the code. Happy to approve
brhooper
approved these changes
May 28, 2026
Contributor
brhooper
left a comment
brhooper
left a comment
There was a problem hiding this comment.
Thanks @mo-jbeaver, the additional tests are helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/metoppv/mo-blue-team/issues/1138, #2360
Acceptance test data: metoppv/improver_test_data#137
Builds on the work from PR: #2387
That PR exposes the option to ignore the grid hash within the spot extract CLI. The option to ignore the grid hash within the SpotExtract plugin was added in #2360.
This PR, adds a unit test covering the new variable added.
Testing: