Add option to ignore the grid hash to the CLI#2387
Closed
gavinevans wants to merge 1 commit into
Closed
Conversation
mo-jbeaver
requested changes
May 21, 2026
Contributor
mo-jbeaver
left a comment
mo-jbeaver
left a comment
There was a problem hiding this comment.
Happy with the changes made. Only small comments about the docstrings. Also, this likely means that the Unit and Acceptance tests are likely out of date or inconsistent.
| spot forecast is passed in, the entire spot cube will be processed and | ||
| returned. The neighbour selection method options have no impact if a | ||
| spot cube is passed in. | ||
| ignore_grid_match: |
Contributor
There was a problem hiding this comment.
Suggested change
| ignore_grid_match: | |
| ignore_grid_match (bool): |
| spot forecast is passed in, the entire spot cube will be processed and | ||
| returned. The neighbour selection method options have no impact if a | ||
| spot cube is passed in. | ||
| """ |
Contributor
There was a problem hiding this comment.
Suggested change
| ignore_grid_match (bool): | |
| If True, the coordinate hash comparison between the diagnostic cube and | |
| the neighbour cube will be ignored. This is not recommended, but | |
| allows the version of Iris and/or Numpy in the plug-in execution | |
| environment to be different from those that generated the neighbour cube. | |
| If False, the grid match check will be performed and an error raised if the | |
| cubes do not match. The default is False, and it is recommended to ensure | |
| that the neighbour cube is generated on the same grid as the diagnostic cube | |
| to avoid any potential issues with incorrect coordinate extraction. | |
| @TODO: Remove this option once the hash calculation is more robust and can | |
| be reliably used across different versions of Iris and Numpy. | |
| """ |
Docstring for the new variable needs to be included, copied from the CLI.
2 tasks
Contributor
Author
|
Superseded by #2388. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/metoppv/mo-blue-team/issues/1138, #2360
Description
This PR exposes the option to ignore the grid hash within the spot extract CLI. The option to ignore the grid hash within the SpotExtract plugin was added in #2360.
Testing: