Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-zero-hits-per-page.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@meilisearch/instant-meilisearch': patch
---

Preserve zero hits per page in non-finite pagination requests.
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,15 @@ describe('Pagination adapter', () => {
expect(searchParams.offset).toBe(6)
})

test('preserves zero hits per page in the request limit', () => {
const searchParams = adaptSearchParams({
...DEFAULT_CONTEXT,
pagination: { page: 0, hitsPerPage: 0, finite: false },
})

expect(searchParams.limit).toBe(0)
})

test('adapting a finite pagination with no placeholderSearch', () => {
const searchParams = adaptSearchParams({
...DEFAULT_CONTEXT,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function setScrollPagination(
}

return {
limit: hitsPerPage + 1,
limit: hitsPerPage === 0 ? 0 : hitsPerPage + 1,
offset: page * hitsPerPage,
}
}
Expand Down
Loading