fix: preserve zero hits-per-page limits#1502
Open
AysajanE wants to merge 1 commit into
Open
Conversation
Signed-off-by: Aysajan Eziz <aeziz@northset.ai>
🦋 Changeset detectedLatest commit: 92e0d82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Strift
self-requested a review
July 17, 2026 06:14
Collaborator
|
Hello @AysajanE, and thanks for your contribution 🙌 This looks good, but CI is currently broken because of a bug in Meilisearch. I'm waiting for meilisearch/meilisearch#6493 to be released so I can merge this 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generate a zero Meilisearch limit when InstantSearch explicitly requests zero hits per page.
Change
.changeset/fix-zero-hits-per-page.mdpackages/instant-meilisearch/src/adapter/search-request-adapter/__tests__/search-params.test.tspackages/instant-meilisearch/src/adapter/search-request-adapter/search-params-adapter.tsChecks
npm test -- --configLoader runner --no-cache packages/instant-meilisearch/src/adapter/search-request-adapter/__tests__/search-params.test.ts— passed in a network-isolated container.Fixes #1365
AI assistance was used; I reviewed and own this change.
Verification
Northset proof-of-pass receipt M-171
Contributor self-run; not maintainer verification.