Skip to content

Wip raw hid#21

Open
maxistar wants to merge 4 commits into
mainfrom
wip_raw_hid
Open

Wip raw hid#21
maxistar wants to merge 4 commits into
mainfrom
wip_raw_hid

Conversation

@maxistar

Copy link
Copy Markdown
Owner

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14759b8dbe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

/ {
behaviors {
raw_layer: raw_layer {
compatible = "zmk,behavior-raw-layer";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add binding for new raw-layer behavior compatible

The new raw_layer node uses compatible = "zmk,behavior-raw-layer", but this change set does not add a corresponding devicetree binding (dts/bindings/...yaml) for that compatible. In Zephyr/ZMK builds, introducing a custom compatible without a binding causes devicetree processing to fail (the node is rejected as having no binding), so firmware builds for this shield will fail before linking.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant