Add matrix-org/jest linting#2973
Merged
Merged
Conversation
Pushing this out to a follow-up task, #2976
MadLittleMods
commented
Dec 14, 2022
MadLittleMods
commented
Dec 14, 2022
MadLittleMods
commented
Dec 14, 2022
| // TODO: There are many cases to refactor away, | ||
| // https://github.com/matrix-org/matrix-js-sdk/issues/2978 | ||
| "jest/no-conditional-expect": "off", | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Testing locally, everything is passing atm ✅:
$ yarn lint:js
yarn run v1.22.18
$ eslint --max-warnings 0 src spec && prettier --check .
Checking formatting...
All matched files use Prettier code style!
✨ Done in 25.68s.
weeman1337
reviewed
Feb 7, 2023
| expect(rooms).toContain(room2); | ||
| }); | ||
|
|
||
| it("Ignores m.predecessor if we don't ask to use it", () => { |
weeman1337
reviewed
Feb 7, 2023
| expect(maySendRedactionForEventSpy).toHaveBeenCalledWith(basePollStartEvent, "@charlie:server.org"); | ||
| }); | ||
|
|
||
| it("does not set poll end event when an earlier end event already exists", async () => { |
weeman1337
reviewed
Feb 7, 2023
| expect(responses.getRelations()).toEqual([responseEventAtEnd, responseEventBeforeEnd]); | ||
| }); | ||
|
|
||
| it("does not set poll end event when sent by invalid user", async () => { |
weeman1337
reviewed
Feb 7, 2023
| expect(poll.isEnded).toBeTruthy(); | ||
| }); | ||
|
|
||
| it("replaces poll end event and refilters when an older end event already exists", async () => { |
weeman1337
reviewed
Feb 7, 2023
| ); | ||
| }); | ||
|
|
||
| it("POST with relative path response including parent", async function () { |
weeman1337
requested review from
andybalaam,
dbkr,
hughns,
kerryarchibald and
weeman1337
and removed request for
hughns and
weeman1337
hughns
approved these changes
Feb 7, 2023
hughns
left a comment
hughns
left a comment
Member
There was a problem hiding this comment.
Rendezvous related changes look good. Thank you.
andybalaam
approved these changes
Feb 10, 2023
SimonBrandner
approved these changes
Feb 10, 2023
SimonBrandner
left a comment
SimonBrandner
left a comment
Contributor
There was a problem hiding this comment.
WebRTC changes LGTM
Contributor
Author
|
Thanks for bringing this to merge @weeman1337 and for the review @hughns @andybalaam @SimonBrandner 🦧 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
matrix-org/jestlintingPart of matrix-org/eslint-plugin-matrix-org#33
Follow-up tasks:
jest/valid-expect: Fixjest/valid-expectlints throughout the codebase #2976jest/valid-expect-in-promise: FlawedDeviceList.spec.tsdoes not wait for async call and assertions #2977jest/no-conditional-expect: Fixjest/no-conditional-expectlints throughout the codebase #2978Todo
eslint-plugin-matrix-orgdependency after Add Jest linting - Add lint to remind you not to leave in an exclusive/focused test eslint-plugin-matrix-org#33 mergesChecklist
This change is marked as an internal change (Task), so will not be included in the changelog.