Add Jest linting - Add lint to remind you not to leave in an exclusive/focused test#33
Merged
Merged
Conversation
MadLittleMods
changed the title
Closed
3 tasks
MadLittleMods
changed the title
Merged
6 tasks
MadLittleMods
requested review from
kerryarchibald and
weeman1337
and removed request for
a team
weeman1337
suggested changes
Nov 10, 2022
weeman1337
left a comment
weeman1337
left a comment
Contributor
There was a problem hiding this comment.
I like the idea adding the rules.
Jest should be added here as well https://github.com/matrix-org/eslint-plugin-matrix-org/blob/main/index.js
richvdh
reviewed
Nov 10, 2022
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
MadLittleMods
commented
Nov 10, 2022
weeman1337
suggested changes
Dec 13, 2022
weeman1337
left a comment
weeman1337
left a comment
Contributor
There was a problem hiding this comment.
@MadLittleMods can you update the branch?
Also it would be nice to have a JS SDK PR that previews the changes, if all the rules are applied. Adapting to code may take some time:
✖ 332 problems (209 errors, 123 warnings)
61 errors and 0 warnings potentially fixable with the `--fix` option.
(output for JS SDK using this branch with main merged)
4 tasks
MadLittleMods
commented
Dec 14, 2022
MadLittleMods
changed the title
weeman1337
approved these changes
Jan 11, 2023
weeman1337
left a comment
weeman1337
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
Thanks for your work on the tests!
weeman1337
reviewed
Feb 2, 2023
weeman1337
force-pushed
the
madlittlemods/no-focused-exclusive-tests
branch
from
7a6fd4d to
f430bfb
Compare
Contributor
Author
|
Thanks for wrangling a release here @weeman1337 😊 This is now part of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Jest linting. Rules: https://github.com/jest-community/eslint-plugin-jest#rules
Spawning from matrix-org/matrix-js-sdk#2856 (comment) where I really only was after
jest/no-focused-teststo remind you not to leave in an exclusive/focused test but it doesn't seem harmful to add the rest of the "recommended" ones. Hopefully we don't have to battle a pile of changes in our downstream repos to get usage adopted.References: