Add sig/manifest.yaml to declare stdlib dependencies#1711
Merged
Conversation
`sig/herb/token_list.rbs` declares a class inheriting from
`SimpleDelegator`, which comes from the `delegate` standard library.
Since `delegate` is a default gem, it does not appear in the gemspec,
and `rbs collection install` cannot resolve it on the consumer side.
With Steep 2.0, this previously-silent issue surfaces as a hard error:
Type checking failed due to error in library RBS file
Cannot find type `SimpleDelegator`
(.../herb-0.10.1/sig/herb/token_list.rbs:4:2)
Diagnostic ID: Ruby::LibraryRBSError
Declare the implicit standard library dependencies in
`sig/manifest.yaml` so downstream users get correct type resolution.
Refs: https://github.com/ruby/rbs/blob/master/docs/gem.md
Contributor
Author
|
@marcoroth we can check the validity of types via At present, some |
Owner
|
Awesome, thank you for investigating @tk0miya! If we move the |
marcoroth
pushed a commit
that referenced
this pull request
May 6, 2026
To avoid the regressions of the RBS definition, this adds automatic RBS validation on CI. This also contains the following changes around RBS: * Update to RBS-4.0 and Steep-2.0 * Manage types of dependencies via rbs_collection.yaml (see https://github.com/ruby/rbs/blob/master/docs/collection.md) ref: #1711 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sig/herb/token_list.rbsdeclares a class inheriting fromSimpleDelegator, which comes from thedelegatestandard library. Sincedelegateis a default gem, it does not appear in the gemspec, andrbs collection installcannot resolve it on the consumer side.With Steep 2.0, this previously-silent issue surfaces as a hard error:
Declare the implicit standard library dependencies in
sig/manifest.yamlso downstream users get correct type resolution.Refs: https://github.com/ruby/rbs/blob/master/docs/gem.md