Skip to content

Ruby: Check RBS validity on CI#1712

Merged
marcoroth merged 4 commits into
marcoroth:mainfrom
tk0miya:rbs_validate
May 6, 2026
Merged

Ruby: Check RBS validity on CI#1712
marcoroth merged 4 commits into
marcoroth:mainfrom
tk0miya:rbs_validate

Conversation

@tk0miya

@tk0miya tk0miya commented May 6, 2026

Copy link
Copy Markdown
Contributor

To avoid the regressions of the RBS definition, this adds automatic RBS validation on CI.

This also contains the following changes around RBS:

ref: #1711 (review)

tk0miya added 4 commits May 6, 2026 23:05
@tk0miya

tk0miya commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

Sorry, I'm not sure why ruby-gem:test failed. Is this related to this change?

    1) Failure:
  Engine::EvaluationTest#test_0022_complex real world example [test/engine/evaluation_test.rb:369]:
  Expected snapshot file to exist: 
  test/snapshots/engine/evaluation_test/test_0022_complex_real_world_example_d8e54f09b6cf5d8199c941a30266ede6.txt
  
  2521 runs, 6869 assertions, 1 failures, 0 errors, 70 skips

@marcoroth marcoroth changed the title Check RBS validity on CI Ruby: Check RBS validity on CI May 6, 2026

@marcoroth marcoroth left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tk0miya! 🙏🏼

(The test is flaky on test, I just re-run CI and its green now)

@marcoroth marcoroth merged commit 62b1318 into marcoroth:main May 6, 2026
30 of 31 checks passed
@tk0miya tk0miya deleted the rbs_validate branch July 5, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants