Skip to content

Linter: Fix actionview-no-silent-helper inside blocks#1642

Merged
marcoroth merged 4 commits into
marcoroth:mainfrom
markokajzer:marko/actionview-no-silent-helper/ignore-helper-calls-in-branch-logic
Apr 18, 2026
Merged

Linter: Fix actionview-no-silent-helper inside blocks#1642
marcoroth merged 4 commits into
marcoroth:mainfrom
markokajzer:marko/actionview-no-silent-helper/ignore-helper-calls-in-branch-logic

Conversation

@markokajzer

@markokajzer markokajzer commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

found some false positives I think

EDIT: closes #1629, closes #1635, closes #1636

conditionals

<% if admin? %>
  <%= link_to "Admin", admin_path %>
<% end %>

loops

<% ["Herb", "Home"].each do %>
  <%= link_to it, home_path %>
<% end %>

@markokajzer

markokajzer commented Apr 18, 2026

Copy link
Copy Markdown
Contributor Author

I just saw that sb mentioned that

This seems to be a regression in 0.9.6, as the same file produces no offenses on 0.9.5.

So this might not be the fix that we want.

However, I noticed that similar rules use visitERB**Content**Node, not visitERBNode, so I was guessing we might need the same here.

Co-Authored-By: Marko Kajzer <markokajzer91@gmail.com>
@marcoroth marcoroth changed the title fix(actionview-no-silent-helper): ignore helper calls in branch logic Linter: Fix actionview-no-silent-helper inside blocks Apr 18, 2026
@marcoroth marcoroth merged commit 46db98e into marcoroth:main Apr 18, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants