Linter: False positives for `actionview-no-silent-helper` in 0.9.6

[janko]

When linting this HTML+ERB file:

<% if true %>
  <%= link_to "Foo", foo_path %>
<% end %>

I get the following offense:

[error] Avoid using <% %> with link_to. Use <%= %> to ensure the helper's output is rendered. (actionview-no-silent-helper)

app/views/building_admin/custom_screensavers/_custom_screensaver.html.erb:1:0

  →   1 │ <% if true %>
        │ ~~~~~~~~~
      2 │   <%= link_to "Foo", foo_path %>
      3 │ <% end %>

This seems to be a regression in 0.9.6, as the same file produces no offenses on 0.9.5.

[Thiteago]

Hey, I’m getting the same false positive in similar code.

<% data.each do | key, value| %>
    <%= hidden_field_tag "form[#{key}]" %>
  <% end %>

This code raises an error saying:

Avoid using `<% %>` with `hidden_field_tag`. Use `<%= %>` to ensure the helper's output is rendered.

I think it is incorrectly detecting the <% %> tags in this case.

[Halvanhelv]

Same

[ccuilla]

I'm getting the same with this:

<% content_for :mobile_header do %>
  <%= link_to :back, { class: "size-12 block mt-6" } do %>
    <%= image_tag "icons/back.svg", alt: "Back icon", class: "size-6" %>
  <% end %>
  <h1 class="block font-bold text-lg">
    Editing a <%= model.class.name %>
  </h1>
  <span class="block size-12">&nbsp;</span>
<% end %>

NOTE: Getting the same warning for image_tag and button_tag.

[doits]

For reproduction here's the link to the playground: https://herb-tools.dev/playground/?tab=diagnostics#DwUgBAlgZmAuBOBXApmEA+AUGMoC8YANhAHYDWA+rAPZgBEAYtdXQDRhTMUAOAhrAAs0WUGGQkAJsKA

[markokajzer]

I just opened a PR to fix the issue, see #1642.

I believe marcoroth is en route to some conferences and the fix might be a bit delayed unfortunately. Otherwise, the issue would have been fixed 5 times over already 😸

In the meantime, keep in mind that rules can be disabled via the .herb.yml file

linter:
  rules:
    actionview-no-silent-helper:
      enabled: false

Sorry for the inconvenience 👍