fix(ci): unbreak main — record #722's deck growth in the size baseline#724
Merged
Conversation
`main` is red at 872ff39. `check-file-size.sh` fails before the Rust toolchain installs, so the whole gate is dark behind it: stella-tui/src/deck_render.rs grew to 1677, over its ceiling of 1676 (+1) stella-tui/src/deck_ui.rs grew to 4049, over its ceiling of 4025 (+24) Neither PR was wrong on its own — this is a collision. #710 and #722 both touch the deck, and #722's baseline was computed against a tree that predated #710's merge. #710 landed first and raised `deck_ui.rs` to 4025; #722 then merged on top and added its own growth over a ceiling that had moved underneath it. Two individually-green PRs, red once combined — the exact shape the merge queue exists to catch (see ci.yml's `merge_group` note), which means neither was queued. Baseline regenerated against the actual tip. Only the two entries move; the other 29 are untouched and the count drops 32→31 (#710's split of settings.rs retired an entry). Worth a second opinion: the guard prefers a new module to a raised ceiling for non-irreducible growth, and `deck_ui.rs` at 4049 is the tree's second-worst file. This raise is the minimum that unblocks a red `main` — +24 and +1, both genuine feature lines from #722 — but if the intent is to hold the line on the deck specifically, the extraction is the better follow-up and this can be reverted into it. Gate, full workspace at this commit: check-no-scratch, check-action-pins, check-file-size, `cargo fmt --check`, `cargo clippy --workspace --all-targets -- -D warnings`, `RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps`, and `cargo test --workspace` — 3,605 tests across 61 suites, 0 failures.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
macanderson
marked this pull request as ready for review
July 26, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red at872ff391.check-file-size.shruns before the Rust toolchain installs, so the entire gate is dark behind it — nothing downstream has reported since #722 landed.This is a collision, not a bad PR
Neither #710 nor #722 was wrong on its own. Both touch the deck, and #722's baseline was computed against a tree that predated #710's merge. #710 landed first and raised
deck_ui.rsto 4025; #722 then merged on top and added its own growth over a ceiling that had moved underneath it.Two individually-green PRs, red once combined — precisely the shape
ci.yml'smerge_groupnote describes the merge queue as existing to prevent, which means neither of them went through the queue.The fix
Baseline regenerated against the actual tip. Only those two entries move; the other 29 are untouched. The count drops 32 → 31 because #710's split of
settings.rsretired an entry.Worth a second opinion
The guard prefers a new module over a raised ceiling for non-irreducible growth, and
deck_ui.rsat 4049 lines is the tree's second-worst file. This raise is the minimum that unblocks a redmain— +24 and +1, both genuine feature lines from #722 — but if the intent is to hold the line on the deck specifically, extraction is the better follow-up and this can be reverted into it. Left as a draft for that reason.Gate
Full workspace at this commit:
check-no-scratch,check-action-pins,check-file-size,cargo fmt --check,cargo clippy --workspace --all-targets -- -D warnings,RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps, andcargo test --workspace— 3,605 tests across 61 suites, 0 failures.Summary by Sourcery
Build: