chore: move the pnpm tooling into website/, where the only package is#726
Merged
Conversation
The repo root carried a `package.json`, `pnpm-workspace.yaml`, and
`pnpm-lock.yaml` describing a workspace that never linked anything. The root
importer was empty (`.: {}`), there were no `workspace:` dependencies, no
catalogs, no overrides, no patches, and exactly one member — `website/`. It
was one package with a workspace wrapped around it.
Nothing was ever shared across the two toolchains. The Rust crates are not
pnpm packages, no `build.rs` shells out to node, there is no wasm/napi bridge,
and stella ships no npm channel (binaries, Homebrew, `curl | sh`). The one
thing that genuinely crosses between Rust and the site is the brand palette,
and its generator is Python: `docs/brand/build.py` writes both
`stella-tui/src/palette.rs` and `website/src/app/tokens.css` and never touches
node.
So the tooling moves to the package it describes:
- `pnpm-lock.yaml` → `website/pnpm-lock.yaml`, with its sole importer promoted
from `website:` to `.`. That is the entire lockfile diff — three lines, no
resolved version changes, verified by `pnpm install --frozen-lockfile`
succeeding against it unchanged.
- `packageManager` and `engines` → `website/package.json`.
- `allowBuilds`, `minimumReleaseAge`, and `minimumReleaseAgeExclude` →
`website/pnpm-workspace.yaml`. The file keeps its name because pnpm 10+
reads those policy settings from it rather than from `.npmrc`; it no longer
declares a `packages:` list, because there is nothing to list.
- The root `package.json` is deleted outright. Its `dev`/`build`/`typecheck`
scripts only forwarded to `pnpm --filter website`, and its `rust:*` and
`gate` aliases had no caller anywhere in the repo.
`docs.yml` gains `defaults.run.working-directory: website` and loses the
root-manifest hop. Two `uses:` steps need explicit paths, since
`working-directory` does not apply to them: `pnpm/action-setup` reads
`packageManager` via `package_json_file`, and `setup-node` hashes the lockfile
via `cache-dependency-path`. Both workflows' path filters drop the three root
filenames — `website/**` already covers their new home.
Requires one setting change outside this repo: Vercel's Root Directory must be
`website`. Noted in the PR and in `website/README.md`.
There was a problem hiding this comment.
Sorry @macanderson, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
macanderson
marked this pull request as ready for review
July 26, 2026 19:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The repo root carried a
package.json,pnpm-workspace.yaml, andpnpm-lock.yamldescribing a workspace that never linked anything:.: {}workspace:protocol dependencieswebsite/It was one package with a workspace wrapped around it. The root
package.jsonhad no dependencies at all; itsdev/build/typecheckscripts only forwarded topnpm --filter website, and itsrust:build/rust:test/rust:lint/rust:fmt/gatealiases have no caller anywhere in the repo (not theMakefile, not.github/, notscripts/, not.githooks/).Nothing is shared across the two toolchains. The Rust crates aren't pnpm packages, the only
build.rsshells out to nothing, there's no wasm/napi bridge, and stella ships no npm channel (binaries, Homebrew,curl | sh— confirmed inRELEASING.mdandrelease.yml). The one thing that genuinely crosses between Rust and the site is the brand palette, and its generator is Python:docs/brand/build.pywrites bothstella-tui/src/palette.rsandwebsite/src/app/tokens.css, viamake brand, and never touches node.What moved
pnpm-lock.yamlwebsite/pnpm-lock.yamlwebsite:→.package.json→packageManager,engineswebsite/package.jsonpnpm-workspace.yaml→allowBuilds,minimumReleaseAge,minimumReleaseAgeExcludewebsite/pnpm-workspace.yamlpackages:website/pnpm-workspace.yamlkeeps its name because pnpm 10+ reads those policy settings from that file rather than from.npmrc. It no longer declares apackages:list, because there is nothing to list. TheminimumReleaseAge: 1440supply-chain gate and theesbuild/sharpbuild approvals are preserved verbatim, comments and all — those were the two things in the root file doing real work.The lockfile diff is three lines. No resolved version changed:
CI
docs.ymlgainsdefaults.run.working-directory: website. Twouses:steps need explicit paths, sinceworking-directorydoesn't apply to them:pnpm/action-setupreadspackageManagerviapackage_json_file: website/package.jsonsetup-nodehashes the lockfile viacache-dependency-path: website/pnpm-lock.yamlBoth workflows' path filters drop the three root filenames —
website/**already covers their new home.ci.ymlonly ever listed them inpaths-ignore, so those lines were about to become dead.Verification
make gatepasses end to end (rebased onto current main, post-fix(ci): unbreak main — record #722's deck growth in the size baseline #724).node_modules, inwebsite/:pnpm install --frozen-lockfile→pnpm typecheck→pnpm buildall succeed. That's precisely thedocs.ymlsequence. The 78-page static build completes.--frozen-lockfilesucceeding is the proof there's no dependency drift — it fails by design if the lockfile would need to change. The lockfile is byte-identical after a clean install.Before merging
Vercel Root Directory →
website. Novercel.jsonexists, so this is a dashboard setting and I can't change it from here.website/README.mdpreviously said the project "auto-detects Next.js + pnpm" and credited the rootpnpm-workspace.yamlfor the build-script approvals, which suggests it may currently install from the repo root. If Root Directory is alreadywebsite, confirm "Include files outside root directory" isn't relied on for the lockfile. I've updated that README to state the requirement.Worth a preview-deploy check on this PR before merge, since that exercises the real Vercel path in a way CI can't.
Not in scope
.dockerignore:47-48references astella-docs/directory that doesn't exist — a genuinely stale entry, but unrelated to this change, so I left it.