Skip to content

Clang format fixes - #1927

Open
aljazdu wants to merge 1 commit into
developfrom
fix/style-fix
Open

Clang format fixes#1927
aljazdu wants to merge 1 commit into
developfrom
fix/style-fix

Conversation

@aljazdu

@aljazdu aljazdu commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Purpose

Specification

None / not applicable

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

AI Usage

Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]

Submitted code was reviewed by a human: YES/NO

The author is taking the responsibility for the contribution: YES/NO

Summary by CodeRabbit

  • Style
    • Improved code formatting and comment readability across camera, stereo-depth, and image-processing components.
    • No changes to functionality, behavior, or public APIs.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 817e4d3c-b6d4-4b42-89dc-3bb5f76574e2

📥 Commits

Reviewing files that changed from the base of the PR and between e03b569 and 6358846.

📒 Files selected for processing (3)
  • include/depthai/pipeline/node/StereoDepth.hpp
  • src/pipeline/node/Camera.cpp
  • src/utility/ImageManipImpl.cpp
📜 Recent review details
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-03-24T22:39:04.364Z
Learnt from: MaticTonin
Repo: luxonis/depthai-core PR: 1732
File: src/pipeline/Pipeline.cpp:705-705
Timestamp: 2026-03-24T22:39:04.364Z
Learning: Do not flag the `!= ""` part of the auto-calibration condition as redundant when it appears in `PipelineImpl::build()` (or closely related pipeline build logic). If the code uses `utility::getEnvAs<std::string>(..., default)` with a default such as `"ON_START"`, the explicit empty-string guard may still be intentional to treat an explicitly empty env var as “OFF/disabled” (or to avoid special-casing elsewhere). Only consider removing `!= ""` if the codebase has an explicit, enforceable guarantee that `DEPTHAI_AUTOCALIBRATION` can never be set to an empty string (e.g., via validated parsing/CI checks); otherwise, keep the guard.

Applied to files:

  • src/pipeline/node/Camera.cpp
🔇 Additional comments (3)
include/depthai/pipeline/node/StereoDepth.hpp (1)

313-314: LGTM!

src/pipeline/node/Camera.cpp (1)

247-247: LGTM!

src/utility/ImageManipImpl.cpp (1)

3018-3018: LGTM!


📝 Walkthrough

Walkthrough

This PR makes formatting-only updates in StereoDepth, Camera, and ImageManipImpl. It wraps one documentation comment, reformats one alphaScaling validation condition, and adjusts one inline comment. Public APIs and behavior do not change.

Changes

Formatting-only cleanup

Layer / File(s) Summary
Alpha-scaling formatting updates
include/depthai/pipeline/node/StereoDepth.hpp, src/pipeline/node/Camera.cpp, src/utility/ImageManipImpl.cpp
The setDefaultProfilePreset warning comment is wrapped across two lines. The alphaScaling range check in Camera::requestOutput is reformatted. An inline // unused comment in WarpH::buildUndistort is spacing-only cleanup.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • luxonis/depthai-core#1881: It changed the same functions and declarations that this PR now reformats without changing behavior.

Suggested reviewers: asahtik, aljazkonec1

Poem

I hopped through comments, neat and light,
And lined the words up rabbit-right.
No logic moved, no paths went far,
I only brushed each little char.
🐇 Tiny edits. Crisp and clean.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the formatting-only changes made to the code.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/style-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aljazdu
aljazdu requested a review from aljazkonec1 August 5, 2026 10:57
@aljazdu aljazdu self-assigned this Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant