Skip to content

DM-51975: Update to cmake 3.12 or later #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fritzm merged 2 commits into from
Jul 27, 2025
Merged

DM-51975: Update to cmake 3.12 or later #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d282acb
Update to cmake 3.12 or later
fritzm Jul 27, 2025
af6240e
Hint github cmake workflow to use downrev python if present
fritzm Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/cmake.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ jobs:
run: |
cmake \
-DCMAKE_INSTALL_PREFIX=${{github.workspace}}/build/install \
-DPython_FIND_STRATEGY=LOCATION \
-B ${{github.workspace}}/build

- name: CMake build
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.1)
cmake_minimum_required(VERSION 3.12)
project(log)

enable_testing()
Expand Down
1 change: 1 addition & 0 deletions python/lsst/log/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
find_package(Python COMPONENTS Development Interpreter)
add_subdirectory(log)

install(
Expand Down
2 changes: 1 addition & 1 deletion tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
find_package(Boost REQUIRED COMPONENTS
find_package(Boost REQUIRED NO_MODULE COMPONENTS
unit_test_framework REQUIRED
)

Expand Down
Loading