Skip to content

DM-51975: Update to cmake 3.12 or later#73

Merged
fritzm merged 2 commits into
mainfrom
tickets/DM-51975
Jul 27, 2025
Merged

DM-51975: Update to cmake 3.12 or later#73
fritzm merged 2 commits into
mainfrom
tickets/DM-51975

Conversation

@fritzm

@fritzm fritzm commented Jul 27, 2025

Copy link
Copy Markdown
Contributor

Newer installations are starting to whinge about soon-to-be-deprecated cmake < 3.10. This upgrades minimal version from 3.1 to 3.10, and also updates to modern find python usage for pybind11.

@fritzm fritzm requested review from mwittgen and timj July 27, 2025 05:02
@fritzm

fritzm commented Jul 27, 2025

Copy link
Copy Markdown
Contributor Author

Oh, oops... cmake seems to be over-eagerly finding more up-to-date python in the downrev matrix builds (good trick). Let me see if I can hint it to keep it from doing that...

@fritzm fritzm force-pushed the tickets/DM-51975 branch from fe6f63c to d304f3a Compare July 27, 2025 05:49
@fritzm fritzm force-pushed the tickets/DM-51975 branch from d304f3a to af6240e Compare July 27, 2025 05:59
@fritzm

fritzm commented Jul 27, 2025

Copy link
Copy Markdown
Contributor Author

Okay, that seems better.

@timj timj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay...

@fritzm fritzm merged commit eaed405 into main Jul 27, 2025
5 checks passed
@fritzm fritzm deleted the tickets/DM-51975 branch July 27, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants