wip(deposition): Allow notifying on manifest changes if policy is warn#6810
Draft
corneliusroemer wants to merge 6 commits into
Draft
wip(deposition): Allow notifying on manifest changes if policy is warn#6810corneliusroemer wants to merge 6 commits into
corneliusroemer wants to merge 6 commits into
Conversation
Working out how hard it would be to send extra notifications for actually submitted sequences - right now we can only report errors via Slack. Example in this case is manifest changes in revision: how to tell us on slack so we can watch out for whether it propagates. This is more PoC, it's probably not worth the hassle right now. Sidenote: I think slack config could be made part of Config to not have to create at every usage point. Related to #6808
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working out how hard it would be to send extra notifications for actually submitted sequences - right now we can only report errors via Slack.
Example in this case is manifest changes in revision: how to tell us on slack so we can watch out for whether it propagates.
This is more PoC, it's probably not worth the hassle right now.
Sidenote: I think slack config could be made part of Config to not have to create at every usage point.
elated to #6808
🚀 Preview: Add
previewlabel to enable