Skip to content

feat: change nvme print flags to verbose #3463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 1 commit into from
Jun 22, 2026
+11 −1
Merged

feat: change nvme print flags to verbose #3463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion plugins/feat/feat-nvme.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ static int feat_get_nsid(struct libnvme_transport_handle *hdl, __u32 nsid,
__u64 result;
int err;
__u32 len = 0;
nvme_print_flags_t flags = NORMAL;

__cleanup_libnvme_free void *buf = NULL;

Expand All @@ -98,9 +99,18 @@ static int feat_get_nsid(struct libnvme_transport_handle *hdl, __u32 nsid,
return err;
}

err = validate_output_format(nvme_args.output_format, &flags);
if (err < 0) {
nvme_show_error("Invalid output format");
return err;
}

if (nvme_args.verbose)
flags |= VERBOSE;

nvme_show_init();

nvme_show_feature(fid, sel, result, buf, len, NORMAL);
nvme_show_feature(fid, sel, result, buf, len, flags);

nvme_show_finish();

Expand Down
Loading