Skip to content

feat: change nvme print flags to verbose#3463

Merged
igaw merged 1 commit into
linux-nvme:masterfrom
ikegami-t:feat-get-verbose
Jun 22, 2026
Merged

feat: change nvme print flags to verbose#3463
igaw merged 1 commit into
linux-nvme:masterfrom
ikegami-t:feat-get-verbose

Conversation

@ikegami-t

Copy link
Copy Markdown
Contributor

Since always set as normal but suitable for the human readable.

Comment thread plugins/feat/feat-nvme.c Outdated
nvme_show_init();

nvme_show_feature(fid, sel, result, buf, len, NORMAL);
nvme_show_feature(fid, sel, result, buf, len, VERBOSE);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the command line args verbose setting be use here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the feat plugin command output is below for example as just output the value itself.

tokunori@tokunori-X570-Taichi:~/nvme-cli$ nvme-build feat arbitration /dev/nvme0
get-feature:0x01 (Arbitration), Current value:0x03030302

Then changed output by the PR verbose print flags is below as the value fields output.

tokunori@tokunori-X570-Taichi:~/nvme-cli$ nvme-build feat arbitration /dev/nvme0
get-feature:0x01 (Arbitration), Current value:0x03030302
        High Priority Weight   (HPW): 4
        Medium Priority Weight (MPW): 4
        Low Priority Weight    (LPW): 4
        Arbitration Burst       (AB): 4

For the reference the following outpus are get-feature comamnd normal and verbose outputs.

tokunori@tokunori-X570-Taichi:~/nvme-cli$ nvme-build get-feature /dev/nvme0 -f 1
get-feature:0x01 (Arbitration), Current value:0x03030302
tokunori@tokunori-X570-Taichi:~/nvme-cli$ nvme-build get-feature /dev/nvme0 -f 1 -v
get-feature:0x01 (Arbitration), Current value:0x03030302
        High Priority Weight   (HPW): 4
        Medium Priority Weight (MPW): 4
        Low Priority Weight    (LPW): 4
        Arbitration Burst       (AB): 4

Seems for the feat plugin command stdout print the vebose output as default is suitable to me. Do you think still the normal output should be keeped by the default for the feat plugin command?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more consistent with the rest of the commands. If you don't provide the verbose flag you just the the raw value. I am not insisting on this but I think it's just a bit odd.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood then just fixed the patch as mentioned. Thank you.

This is to be consistent with the rest of the commands.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
@igaw igaw merged commit 51f97a6 into linux-nvme:master Jun 22, 2026
30 checks passed
@igaw

igaw commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants