feat: change nvme print flags to verbose#3463
Conversation
| nvme_show_init(); | ||
|
|
||
| nvme_show_feature(fid, sel, result, buf, len, NORMAL); | ||
| nvme_show_feature(fid, sel, result, buf, len, VERBOSE); |
There was a problem hiding this comment.
Should the command line args verbose setting be use here?
There was a problem hiding this comment.
Currently the feat plugin command output is below for example as just output the value itself.
tokunori@tokunori-X570-Taichi:~/nvme-cli$ nvme-build feat arbitration /dev/nvme0
get-feature:0x01 (Arbitration), Current value:0x03030302Then changed output by the PR verbose print flags is below as the value fields output.
tokunori@tokunori-X570-Taichi:~/nvme-cli$ nvme-build feat arbitration /dev/nvme0
get-feature:0x01 (Arbitration), Current value:0x03030302
High Priority Weight (HPW): 4
Medium Priority Weight (MPW): 4
Low Priority Weight (LPW): 4
Arbitration Burst (AB): 4For the reference the following outpus are get-feature comamnd normal and verbose outputs.
tokunori@tokunori-X570-Taichi:~/nvme-cli$ nvme-build get-feature /dev/nvme0 -f 1
get-feature:0x01 (Arbitration), Current value:0x03030302
tokunori@tokunori-X570-Taichi:~/nvme-cli$ nvme-build get-feature /dev/nvme0 -f 1 -v
get-feature:0x01 (Arbitration), Current value:0x03030302
High Priority Weight (HPW): 4
Medium Priority Weight (MPW): 4
Low Priority Weight (LPW): 4
Arbitration Burst (AB): 4Seems for the feat plugin command stdout print the vebose output as default is suitable to me. Do you think still the normal output should be keeped by the default for the feat plugin command?
There was a problem hiding this comment.
I think it would be more consistent with the rest of the commands. If you don't provide the verbose flag you just the the raw value. I am not insisting on this but I think it's just a bit odd.
There was a problem hiding this comment.
Understood then just fixed the patch as mentioned. Thank you.
This is to be consistent with the rest of the commands. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
8ab15e4 to
cd7a9d2
Compare
|
Thanks! |
Since always set as normal but suitable for the human readable.