feat: webhooks listen/logs, phonenumbers set - #29
Merged
Conversation
abhiramkast
force-pushed
the
pr2-webhooks-phonenumbers
branch
2 times, most recently
from
April 14, 2026 19:25
62d0cf7 to
21fa7e0
Compare
jflayhart
reviewed
Apr 14, 2026
Comment on lines
+179
to
+184
| // Prevent seenIds from growing unbounded | ||
| if (seenIds.size > 5000) { | ||
| const entries = [...seenIds]; | ||
| for (let i = 0; i < 2500; i++) { | ||
| seenIds.delete(entries[i]); | ||
| } |
Collaborator
There was a problem hiding this comment.
why not simply pop oldest off the queue when we reach max size? for example this is constant time lookup and a more stable memory ceiling:
const key = log.event_id + ':' + log.attempt;
if (seenIds.has(key)) continue;
seenIds.add(key);
if (seenIds.size > 5000) {
seenIds.delete(seenIds.values().next().value);
}
abhiramkast
force-pushed
the
pr2-webhooks-phonenumbers
branch
from
April 14, 2026 20:27
21fa7e0 to
d9b5555
Compare
jflayhart
approved these changes
Apr 14, 2026
jflayhart
left a comment
jflayhart
left a comment
Collaborator
There was a problem hiding this comment.
left a comment simpler queue/unbounded growth management
- webhooks listen: WebSocket relay with --forward-to for local dev - webhooks logs: view recent webhook delivery logs - webhooks events: improved output formatting - phonenumbers set: pick default phone for MULTI lines - voicememo: added from flag support
abhiramkast
force-pushed
the
pr2-webhooks-phonenumbers
branch
from
April 15, 2026 00:06
d9b5555 to
de62ea7
Compare
* chore: command audit, error handling cleanup, and test updates - chats create: dynamic error messages based on account type, telemetry - format.ts: improved output formatting across commands - doctor.ts: updated diagnostics - init.ts: cleanup - All commands: consistent error handling, clean flag descriptions - Test updates for new error messages and SDK methods - Removed dead signup tests (replaced by OTP flow) * refactor: extract shared auth flow into auth-flow.ts Login and signup now call the same runAuthFlow() function. Both handle existing users (welcome back) and new users (provision) identically. Removes duplicate code. * feat: session check, whoami cleanup, unhide init/profile, attachment-url - auth-flow: check existing session before signup/login, block if logged in - auth-flow: remove phone number prompt (unused for shared lines) - whoami: only show fields that exist, no misleading "phone not set" - unhide init and all profile commands - config: remove dead sandbox profile check from saveProfile - chats create + messages send: add --attachment-url flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webhooks listen: WebSocket relay with--forward-tofor local webhook developmentwebhooks logs: view recent webhook delivery logswebhooks events: improved output formattingphonenumbers set: pick default phone for MULTI linesvoicememo: added from flag supportPR Chain
This is PR 2 of 3 (depends on #28). Merge order: PR 1 → PR 2 → PR 3