Skip to content

chore: command audit, error handling cleanup, and test updates - #30

Merged
abhiramkast merged 3 commits into
pr2-webhooks-phonenumbersfrom
pr3-command-audit-cleanup
Apr 15, 2026
Merged

chore: command audit, error handling cleanup, and test updates#30
abhiramkast merged 3 commits into
pr2-webhooks-phonenumbersfrom
pr3-command-audit-cleanup

Conversation

@abhiramkast

Copy link
Copy Markdown
Contributor

Summary

  • chats create: dynamic error messages based on account type, telemetry breadcrumb
  • format.ts: improved output formatting across commands
  • doctor.ts: updated diagnostics
  • All commands: consistent error handling, clean flag descriptions
  • Test updates for new error messages and SDK methods
  • Removed dead signup tests (replaced by OTP flow)

PR Chain

This is PR 3 of 3 (depends on #29). Merge order: PR 1 → PR 2 → PR 3

@abhiramkast
abhiramkast requested a review from jflayhart as a code owner April 14, 2026 16:20
@abhiramkast
abhiramkast force-pushed the pr2-webhooks-phonenumbers branch from 52b94a7 to 3c3d736 Compare April 14, 2026 16:24
@abhiramkast
abhiramkast force-pushed the pr3-command-audit-cleanup branch 2 times, most recently from 0adc151 to cb2d92c Compare April 14, 2026 19:19
@abhiramkast
abhiramkast force-pushed the pr2-webhooks-phonenumbers branch from 62d0cf7 to 21fa7e0 Compare April 14, 2026 19:25
@abhiramkast
abhiramkast force-pushed the pr3-command-audit-cleanup branch from cb2d92c to 61f922d Compare April 14, 2026 19:25
@abhiramkast
abhiramkast force-pushed the pr2-webhooks-phonenumbers branch from 21fa7e0 to d9b5555 Compare April 14, 2026 20:27
@abhiramkast
abhiramkast force-pushed the pr3-command-audit-cleanup branch from 61f922d to f38b296 Compare April 14, 2026 20:27
@abhiramkast
abhiramkast force-pushed the pr2-webhooks-phonenumbers branch from d9b5555 to de62ea7 Compare April 15, 2026 00:06
- chats create: dynamic error messages based on account type, telemetry
- format.ts: improved output formatting across commands
- doctor.ts: updated diagnostics
- init.ts: cleanup
- All commands: consistent error handling, clean flag descriptions
- Test updates for new error messages and SDK methods
- Removed dead signup tests (replaced by OTP flow)
Login and signup now call the same runAuthFlow() function.
Both handle existing users (welcome back) and new users
(provision) identically. Removes duplicate code.
@abhiramkast
abhiramkast force-pushed the pr3-command-audit-cleanup branch from 687980a to f82d14f Compare April 15, 2026 00:06
- auth-flow: check existing session before signup/login, block if logged in
- auth-flow: remove phone number prompt (unused for shared lines)
- whoami: only show fields that exist, no misleading "phone not set"
- unhide init and all profile commands
- config: remove dead sandbox profile check from saveProfile
- chats create + messages send: add --attachment-url flag
@abhiramkast
abhiramkast merged commit 7abe9c9 into pr2-webhooks-phonenumbers Apr 15, 2026
@abhiramkast
abhiramkast deleted the pr3-command-audit-cleanup branch April 15, 2026 04:47
abhiramkast added a commit that referenced this pull request Apr 15, 2026
* feat: webhooks listen/logs, phonenumbers set, voicememo updates

- webhooks listen: WebSocket relay with --forward-to for local dev
- webhooks logs: view recent webhook delivery logs
- webhooks events: improved output formatting
- phonenumbers set: pick default phone for MULTI lines
- voicememo: added from flag support

* fix: update listen test for new error handling

* fix: import ws for Node 20 WebSocket compatibility

* revert: remove voicememo from flag change (separate PR)

* fix: use rolling eviction for dedup set instead of bulk clear

* chore: command audit, error handling cleanup, and test updates (#30)

* chore: command audit, error handling cleanup, and test updates

- chats create: dynamic error messages based on account type, telemetry
- format.ts: improved output formatting across commands
- doctor.ts: updated diagnostics
- init.ts: cleanup
- All commands: consistent error handling, clean flag descriptions
- Test updates for new error messages and SDK methods
- Removed dead signup tests (replaced by OTP flow)

* refactor: extract shared auth flow into auth-flow.ts

Login and signup now call the same runAuthFlow() function.
Both handle existing users (welcome back) and new users
(provision) identically. Removes duplicate code.

* feat: session check, whoami cleanup, unhide init/profile, attachment-url

- auth-flow: check existing session before signup/login, block if logged in
- auth-flow: remove phone number prompt (unused for shared lines)
- whoami: only show fields that exist, no misleading "phone not set"
- unhide init and all profile commands
- config: remove dead sandbox profile check from saveProfile
- chats create + messages send: add --attachment-url flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants