Skip to content

fix: remove preinstalled flag #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dennisvankekem wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −7
Open

fix: remove preinstalled flag #812

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56ca993
fix: remove preinstalled flag
dennisvankekem Jun 30, 2026
39a8cbd
fix: rmeoved now invalid code block
dennisvankekem Jun 30, 2026
dadf2a9
Merge remote-tracking branch 'origin/main' into APL-1970
svcAPLBot Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/components/modals/ConfigureGitModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,6 @@ export default function ConfigureGitModal({ open, onClose }: ConfigureGitModalPr
user: { isPlatformAdmin },
settings: {
cluster: { domainSuffix },
otomi: { isPreInstalled },
},
} = useSession()

Expand All @@ -259,7 +258,7 @@ export default function ConfigureGitModal({ open, onClose }: ConfigureGitModalPr
const actualOpen = useMemo(() => (isControlled ? !!open : !!showGitWizard), [isControlled, open, showGitWizard])

const { data: gitSettings, isFetching: isFetchingGitSettings } = useGetGitSettingsQuery(undefined, {
skip: !isPlatformAdmin || !isPreInstalled || !actualOpen,
skip: !isPlatformAdmin || !actualOpen,
})

const defaultGitUrl = gitSettings?.repoUrl || ''
Expand Down Expand Up @@ -306,10 +305,6 @@ export default function ConfigureGitModal({ open, onClose }: ConfigureGitModalPr
if (showGitWizard === undefined) setShowGitWizard(true)
}, [showGitWizard, setShowGitWizard])

useEffect(() => {
if (!isPreInstalled && !isControlled) setShowGitWizard(false)
}, [isPreInstalled, isControlled, setShowGitWizard])

useEffect(() => {
if (!actualOpen) {
resetModalState()
Expand Down Expand Up @@ -406,7 +401,7 @@ export default function ConfigureGitModal({ open, onClose }: ConfigureGitModalPr
}
}

if (!isPlatformAdmin || !isPreInstalled) return null
if (!isPlatformAdmin) return null
if (!isControlled && !showGitWizard) return null

return (
Expand Down