Skip to content

fix: remove preinstalled flag#812

Open
dennisvankekem wants to merge 3 commits into
mainfrom
APL-1970
Open

fix: remove preinstalled flag#812
dennisvankekem wants to merge 3 commits into
mainfrom
APL-1970

Conversation

@dennisvankekem

Copy link
Copy Markdown
Collaborator

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

Copilot AI review requested due to automatic review settings June 30, 2026 11:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes reliance on the isPreInstalled session flag in the Git configuration modal flow, and updates the settings-info API typing to no longer expose a Git password field.

Changes:

  • Removes isPreInstalled gating from ConfigureGitModal for rendering and for fetching Git settings.
  • Updates GetSettingsInfoApiResponse typing to drop otomi.git.password.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/redux/otomiApi.ts Removes password from the GetSettingsInfoApiResponse.otomi.git shape.
src/components/modals/ConfigureGitModal.tsx Removes isPreInstalled-based logic for showing the modal and for querying Git settings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/modals/ConfigureGitModal.tsx Outdated
Copilot AI review requested due to automatic review settings June 30, 2026 13:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants