Skip to content

fix: add missing vite source aliases for transitive @pen/* workspace deps #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JayaKrishnaNamburu wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −1
Open

fix: add missing vite source aliases for transitive @pen/* workspace deps #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc002d9
fix: add missing vite source aliases for transitive @pen/* workspace …
JayaKrishnaNamburu Jun 24, 2026
751498e
add missing path mappings for server ts config
JayaKrishnaNamburu Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion playground/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,19 @@
"types": ["vite/client"],
"baseUrl": ".",
"paths": {
"@pen/assets-memory": ["../packages/tooling/assets-memory/src/index.ts"],
"@pen/ai": ["../packages/extensions/ai/src/index.ts"],
"@pen/ai-autocomplete": ["../packages/extensions/ai-autocomplete/src/index.ts"],
"@pen/ai-skills": ["../packages/extensions/ai-skills/src/index.ts"],
"@pen/ai-suggestions": ["../packages/extensions/ai-suggestions/src/index.ts"],
"@pen/ai-tools": ["../packages/extensions/ai-tools/src/index.ts"],
"@pen/content-ops": ["../packages/shared/content-ops/src/index.ts"],
"@pen/core": ["../packages/core/src/index.ts"],
"@pen/crdt-yjs": ["../packages/crdt/yjs/src/index.ts"],
"@pen/dom": ["../packages/rendering/dom/src/index.ts"],
"@pen/database": ["../packages/extensions/database/src/index.ts"],
"@pen/export-html": ["../packages/extensions/export-html/src/index.ts"],
"@pen/export-json": ["../packages/extensions/export-json/src/index.ts"],
"@pen/export-markdown": ["../packages/extensions/export-markdown/src/index.ts"],
"@pen/import-html": ["../packages/extensions/import-html/src/index.ts"],
"@pen/import-markdown": ["../packages/extensions/import-markdown/src/index.ts"],
Expand All @@ -27,7 +31,11 @@
"@pen/schema-default": ["../packages/schema/default/src/index.ts"],
"@pen/search": ["../packages/extensions/search/src/index.ts"],
"@pen/shortcuts": ["../packages/extensions/shortcuts/src/index.ts"],
"@pen/types": ["../packages/types/src/index.ts"]
"@pen/types": ["../packages/types/src/index.ts"],
"@pen/markdown-serialization": ["../packages/shared/markdown-serialization/src/index.ts"],
"@pen/undo": ["../packages/extensions/undo/src/index.ts"],
"@pen/document-ops": ["../packages/extensions/document-ops/src/index.ts"],
"@pen/delta-stream": ["../packages/extensions/delta-stream/src/index.ts"]

@JayaKrishnaNamburu JayaKrishnaNamburu Jun 25, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, when the mappings are missing. The deps are being resolved using the symlinks from their respective dist folders as expected. As they are exposed via exports field.

But if the server is ran with a clean setup. There is no previous build runs and so the server is breaking. Then i noticed there are path mappings and added them. I am not sure, if path mappings / symlinks is followed currently. Let me know, i can revert these changes.

And next, the package @pen/ai is breaking because of some types issue in extension.ts file. Partially why the builds are failing and server is failing to start

}
},
"include": ["src"]
Expand Down
13 changes: 13 additions & 0 deletions playground/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,19 @@ const PEN_SOURCE_ALIASES = {
"@pen/shortcuts": fileURLToPath(
new URL("../packages/extensions/shortcuts/src/index.ts", import.meta.url),
),
"@pen/content-ops": fileURLToPath(
new URL("../packages/shared/content-ops/src/index.ts", import.meta.url),
),
"@pen/dom": fileURLToPath(new URL("../packages/rendering/dom/src", import.meta.url)),
"@pen/history": fileURLToPath(
new URL("../packages/extensions/history/src/index.ts", import.meta.url),
),
"@pen/markdown-serialization": fileURLToPath(
new URL("../packages/shared/markdown-serialization/src/index.ts", import.meta.url),
),
"@pen/assets-memory": fileURLToPath(
new URL("../packages/tooling/assets-memory/src/index.ts", import.meta.url)
),
"@pen/types": fileURLToPath(new URL("../packages/types/src/index.ts", import.meta.url)),
"@pen/undo": fileURLToPath(
new URL("../packages/extensions/undo/src/index.ts", import.meta.url),
Expand Down