fix: add missing vite source aliases for transitive @pen/* workspace deps#2
Open
JayaKrishnaNamburu wants to merge 2 commits into
Open
fix: add missing vite source aliases for transitive @pen/* workspace deps#2JayaKrishnaNamburu wants to merge 2 commits into
JayaKrishnaNamburu wants to merge 2 commits into
Conversation
| "@pen/markdown-serialization": ["../packages/shared/markdown-serialization/src/index.ts"], | ||
| "@pen/undo": ["../packages/extensions/undo/src/index.ts"], | ||
| "@pen/document-ops": ["../packages/extensions/document-ops/src/index.ts"], | ||
| "@pen/delta-stream": ["../packages/extensions/delta-stream/src/index.ts"] |
Author
There was a problem hiding this comment.
So, when the mappings are missing. The deps are being resolved using the symlinks from their respective dist folders as expected. As they are exposed via exports field.
But if the server is ran with a clean setup. There is no previous build runs and so the server is breaking. Then i noticed there are path mappings and added them. I am not sure, if path mappings / symlinks is followed currently. Let me know, i can revert these changes.
And next, the package @pen/ai is breaking because of some types issue in extension.ts file. Partially why the builds are failing and server is failing to start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm devfails because several@pen/*packages aliased to source invite.config.tsimport other local packages that aren't aliased, causing vite to look for a non-existentdist/. Added the four missing aliases for transitive workspace dependencies.Post adding the missing alias paths, the local dev server is working fine. And able to see the UI at
http://localhost:5174.Reproduction
To reproduce the issue, run
npm run clean. Which clears out all the existingnode_modulesandbuildfiles. And then do a fresh install andnpm run dev. If the builds are already ran ones without this change, the dist persist from previous builds. So on clean install and dev builds seems to re-trigger the bug.