fix: use copyPackage instead of syncSources for series copies#125
Merged
Conversation
syncSources doesn't specify a source series or version, so Launchpad can't correctly resolve which binaries to copy. copyPackage takes explicit source_name and version, matching how promote() already works. Also fixes: - has_published_binaries: 'not builds' returned True when no builds existed, treating "no builds" as "has binaries" - Handle obsolete series gracefully (like promote does) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rtibbles
force-pushed
the
fix/use-copyPackage-for-series-copy
branch
from
a5c5154 to
b0f9062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
syncSourceswithcopyPackagefor copying packages across series within the PPA.syncSourcesdoesn't specify a source series or version, so Launchpad can't correctly resolve which binaries to include — causingsource has no binaries to be copiederrors even when binaries are published.copyPackagetakes explicitsource_nameandversion, matching howpromote()already works.Also fixes:
has_published_binaries:not buildsreturnedTruewhen no builds existedpromotedoes)References
kolibri-server 0.5.1-0ubuntu1 in noble (source has no binaries to be copied)Reviewer guidance
The core change is
syncSources→copyPackageinperform_queued_copies. The queue now stores(name, version)tuples instead of just names. Tests updated to match.AI usage
Claude Code identified that
syncSourceswas the wrong API (no version/series targeting) and switched tocopyPackagewhich matches the pattern already used bypromote(). All 47 tests pass.