fix: replace wait-for-builds with wait-for-published and fix copy errors#126
Merged
Merged
Conversation
rtibbles
force-pushed
the
fix/wait-for-published-and-copy-errors
branch
from
caa1e1f to
fe435ac
Compare
- Replace wait-for-builds with wait-for-published: checks getPublishedBinaries status instead of build states, since "Successfully built" != "published" - Auto-discovery mode: without --series, discovers all series with published sources and waits until every one also has published binaries - Per-series error handling in syncSources copies: one series failing no longer crashes the entire run; failures are collected and reported at end - Fix has_published_binaries: 'not builds' returned True when no builds existed - Add --series flag to copy-to-series for local testing on non-Ubuntu systems - Update workflow: wait_for_source_published and wait_for_copies_published Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rtibbles
force-pushed
the
fix/wait-for-published-and-copy-errors
branch
from
fe435ac to
4088dab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
wait-for-buildswithwait-for-published— checksgetPublishedBinariesstatus instead of build states, because "Successfully built" does not mean "published and available for copy". This was the root cause of the "source has no binaries to be copied" error.Also adds per-series error handling so one failing series doesn't crash the entire copy run, making the pipeline idempotent and re-runnable.
References
Reviewer guidance
Key changes:
wait_for_published()replaceswait_for_builds()— pollsgetPublishedBinariesinstead of build states--series): finds all series with published sources, waits for all to have published binariesperform_queued_copies(): catchesBadRequestper-series, logs errors, continues to next serieshas_published_binaries: fixed invertednot buildslogicwait_for_source_published(source series only) →copy_to_other_distributions→wait_for_copies_published(all series auto-discovered)AI usage
Claude Code implemented the changes, with all Launchpad API interactions tested live against the kolibri-proposed PPA. 42 unit tests pass.