Skip to content

improve performance of the date/time transformer during feature decoding #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cportele wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improve performance of the date/time transformer during feature decoding #559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions ...va/de/ii/xtraplatform/features/domain/transform/FeaturePropertyTransformerDateFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import java.time.ZoneId;
import java.time.ZonedDateTime;
import java.time.format.DateTimeFormatter;
import java.time.temporal.ChronoField;
import java.time.temporal.TemporalAccessor;
import java.util.List;
import org.immutables.value.Value;
Expand All @@ -30,6 +31,9 @@ public interface FeaturePropertyTransformerDateFormat extends FeaturePropertyVal
ZoneId UTC = ZoneId.of("UTC");
String DATETIME_FORMAT = "yyyy-MM-dd'T'HH:mm:ssZZZZZ";
String DATE_FORMAT = "yyyy-MM-dd";
// built once; rebuilding per value (and parseBest's throwing query fallbacks) showed up in
// profiling
DateTimeFormatter PARSER = DateTimeFormatter.ofPattern("yyyy-MM-dd[['T'][' ']HH:mm:ss][.SSS][X]");

@Override
default String getType() {
Expand All @@ -43,15 +47,19 @@ default List<SchemaBase.Type> getSupportedPropertyTypes() {

ZoneId getDefaultTimeZone();

// cached per transformer instance instead of rebuilt for every value
@Value.Lazy
default DateTimeFormatter formatter() {
return DateTimeFormatter.ofPattern(getParameter());
}

@Override
default String transform(String currentPropertyPath, String input) {
// TODO: variable fractions
try {
DateTimeFormatter formatter = DateTimeFormatter.ofPattern(getParameter());

ZonedDateTime zdt = parse(input, getDefaultTimeZone());

return formatter.format(zdt);
return formatter().format(zdt);
} catch (Throwable e) {
LOGGER.warn(
"{} transformation for property '{}' with value '{}' failed: {}",
Expand All @@ -65,21 +73,17 @@ default String transform(String currentPropertyPath, String input) {
}

static ZonedDateTime parse(String input, ZoneId defaultTimeZone) {
DateTimeFormatter parser =
DateTimeFormatter.ofPattern("yyyy-MM-dd[['T'][' ']HH:mm:ss][.SSS][X]");
// Parse once and branch on the resolved fields. parseBest instead tries OffsetDateTime/
// LocalDateTime/LocalDate via queries that throw — filling in a stack trace — for every value
// without an offset, which is costly when applied per feature.
TemporalAccessor ta = PARSER.parse(input);

TemporalAccessor ta =
parser.parseBest(input, OffsetDateTime::from, LocalDateTime::from, LocalDate::from);

if (ta instanceof OffsetDateTime) {
return ((OffsetDateTime) ta).atZoneSameInstant(UTC);
} else if (ta instanceof LocalDateTime) {
return ((LocalDateTime) ta).atZone(defaultTimeZone).withZoneSameInstant(UTC);
} else if (ta instanceof LocalDate) {
return ((LocalDate) ta).atStartOfDay(UTC);
if (ta.isSupported(ChronoField.OFFSET_SECONDS)) {
return OffsetDateTime.from(ta).atZoneSameInstant(UTC);
}

throw new IllegalArgumentException(
String.format("Input '%s' could not be parsed as a date/time value", input));
if (ta.isSupported(ChronoField.HOUR_OF_DAY)) {
return LocalDateTime.from(ta).atZone(defaultTimeZone).withZoneSameInstant(UTC);
}
return LocalDate.from(ta).atStartOfDay(UTC);
}
}
Loading