improve performance of the date/time transformer during feature decoding#559
Open
cportele wants to merge 1 commit into
Open
improve performance of the date/time transformer during feature decoding#559cportele wants to merge 1 commit into
cportele wants to merge 1 commit into
Conversation
The DATE_FORMAT value transformer did avoidable work for every value: - it rebuilt the input parser and the output formatter on each call; - parse() used parseBest with OffsetDateTime/LocalDateTime/LocalDate queries, so every value without an offset threw - and filled in a stack trace - before falling through to the next query. Now the input parser is a shared constant, the output formatter is cached per transformer, and parse() resolves the value once and branches on the fields that are present (offset / time / date) instead of throwing. parse() keeps its signature for its other caller; output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DATE_FORMAT value transformer did avoidable work for every value:
Now the input parser is a shared constant, the output formatter is cached per transformer, and parse() resolves the value once and branches on the fields that are present (offset / time / date) instead of throwing. parse() keeps its signature for its other caller; output is unchanged.