Split workflows by trigger to restrict when deploys occur#27
Draft
ronpandolfi wants to merge 1 commit into
Draft
Split workflows by trigger to restrict when deploys occur#27ronpandolfi wants to merge 1 commit into
ronpandolfi wants to merge 1 commit into
Conversation
ronpandolfi
marked this pull request as draft
May 1, 2023 23:14
Codecov Report
@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 5 5
Lines 305 305
=======================================
Hits 294 294
Misses 11 11 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address a problem with the current workflow structure: tags pushed to PRs trigger deployment before merge. This issue can be avoided by not tagging branches other than
main.This proposed PR is complex in structure, has significant code duplication, and needs extensive testing. I'm marking it as a draft and leaving it here for future work.
TODO: