Revert to not checking branch before deploy#28
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #28 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 5 5
Lines 305 305
=======================================
Hits 294 294
Misses 11 11 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts f01b44e
The above commit is problematic because
github.refcan never be bothrefs/tags/*andrefs/heads/main. The only issue with the previous behavior is that pushed tags will deploy even if they are only in a PR (before merging to master). This is non-ideal, but workable if you are aware of the behavior.I advise that we be careful to only apply tags to the main branch directly to avoid this edge case.
An alternative workflow structure is proposed in #27, however extensive testing is likely required. I recommend to postpone reviewing #27 to post-publication.