feat(datasets): data-source UI overhaul for public datasets (DATA-4..7)#94
Merged
Conversation
Rework the Public datasets sidebar so it scales as the corpus catalogue grows while keeping local/private upload the primary path. - DATA-4: replace the flat dataset radio with a searchable selectbox that shows each corpus' short name + language·size caption, description, and home link. Promote PUBLIC_DATASET_REGISTRY to structured entries (short/language/size/description/link; loader+monitor preserved). - DATA-5: drop the per-source participant/text narrowing (PoTeC Texts/Readers, MultiplEYE Sessions/Stimuli). Each loader now reads the whole corpus; the global Narrow by filters scope it. Headless load_potec/load_multipleye keep their readers/texts/sessions/stimuli args. - DATA-6: show an "Expected files" expander per loader listing the directory tree + file-name patterns it looks for. - DATA-7: replace the always-on "Download if missing" checkbox with a found-vs-Download status (datasets.potec_present / onestop_present / multipleye_inventory) + a one-click Download button, so an already downloaded corpus never re-checks the network. Adds datasets.potec_present / onestop_present; shared app helpers _dataset_dir_input / _dataset_access_status. Tests: detection unit tests + per-loader access-UI smoke test. Docs synced (CHANGELOG, CLAUDE.md, docs/onestop.md, docs/multipleye.md, IMPROVEMENTS.md). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… AOI writes Review follow-ups for DATA-4..7: - potec_present now requires every text's word + char AOI files (not just one). DATA-5 makes the loader read the whole corpus, so a partial tree would otherwise report "Found" and then crash mid-load (_potec_words raises on the first missing text) with no Download button to recover. Requiring all of them lets the status offer Download, which self-heals. - download_potec writes each AOI file via a temp + atomic replace (like download_onestop), so an interrupted fetch can't leave a truncated file that is_file()/potec_present would treat as complete. - Type the _dataset_access_status download callback param. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
OmerShubi
force-pushed
the
claude/pedantic-sinoussi-c6586b
branch
from
41de7d1 to
f2169a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks the Public datasets sidebar so it scales as the corpus catalogue grows (toward dozens of corpora), while keeping load a local/private dataset the primary path. Implements
DATA-4 … DATA-7fromIMPROVEMENTS.md.st.selectboxshowing each corpus' short name + alanguage · sizecaption, one-line description, and Dataset home ↗ link.PUBLIC_DATASET_REGISTRYpromoted to structured entries (short/language/size/description/link;loader+monitorpreserved). Selection still ridespublic_dataset_choice(full label → deep-link/session round-trips).load_potec/load_multipleyekeep theirreaders/texts/sessions/stimuliargs.datasets.potec_present/onestop_present/multipleye_inventory) + a one-click ⬇ Download button — an already-downloaded corpus never re-checks the network. Column-mapping unchanged.Implementation notes
datasets.potec_present/onestop_present; shared app helpers_dataset_dir_input/_dataset_access_status.readers/texts/sessions/stimuli/downloadargs; thedatasets-module functions are untouched.Behavior change to flag
DATA-5 means PoTeC now loads all 900 trials (75 readers × 12 texts) up front instead of a default subset, then Narrow by scopes it.
Tests
potec_present/onestop_presentdetection unit tests.test_each_public_dataset_loader_ui_renderssmoke-tests all three real loaders;test_potec_source_rendersupdated for the selectbox.test_group_effect_size, a scipy/NaN env issue that fails identically onmain).Docs
CHANGELOG,
scanpath_studio/CLAUDE.md,docs/onestop.md,docs/multipleye.md, IMPROVEMENTS.md (DATA-4…7 →Pending approval).🤖 Generated with Claude Code