WIP build: disable inlining for nodeup builds#18265
Open
hakman wants to merge 3 commits intokubernetes:masterfrom
Open
WIP build: disable inlining for nodeup builds#18265hakman wants to merge 3 commits intokubernetes:masterfrom
hakman wants to merge 3 commits intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
hakman
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Apply -gcflags=all=-l only to nodeup release builds to reduce the nodeup binary size without changing compiler flags for kops, protokube, or channels. Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
hakman
force-pushed
the
nodeup-disable-inlining
branch
from
cc3a500 to
e9acd03
Compare
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
k8s-ci-robot
added
size/XL
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply
-gcflags=all=-lonly to nodeup release builds to reduce the nodeup binary size without changing compiler flags for kops, protokube, or channels.