Skip to content

Commit e9acd03

Browse files
committed
build: disable inlining for nodeup builds
Apply -gcflags=all=-l only to nodeup release builds to reduce the nodeup binary size without changing compiler flags for kops, protokube, or channels. Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
1 parent 1d36e0c commit e9acd03

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

Makefile

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,9 @@ CGO_ENABLED=0
8383
export CGO_ENABLED
8484
BUILDFLAGS=-trimpath -buildvcs=false
8585

86+
ifndef DEBUGGABLE
87+
NODEUP_GCFLAGS?=-gcflags=all=-l
88+
endif
8689

8790
# Go exports:
8891
LDFLAGS := -ldflags=all=
@@ -210,7 +213,7 @@ crossbuild: crossbuild-kops-linux-amd64 crossbuild-kops-linux-arm64 crossbuild-k
210213
.PHONY: nodeup-amd64 nodeup-arm64
211214
nodeup-amd64 nodeup-arm64: nodeup-%:
212215
mkdir -p ${DIST}/linux/$*
213-
GOOS=linux GOARCH=$* go build ${GCFLAGS} ${BUILDFLAGS} ${EXTRA_BUILDFLAGS} -o ${DIST}/linux/$*/nodeup ${LDFLAGS}"${EXTRA_LDFLAGS} -X k8s.io/kops.Version=${VERSION} -X k8s.io/kops.GitVersion=${GITSHA}" k8s.io/kops/cmd/nodeup
216+
GOOS=linux GOARCH=$* go build ${GCFLAGS} ${NODEUP_GCFLAGS} ${BUILDFLAGS} ${EXTRA_BUILDFLAGS} -o ${DIST}/linux/$*/nodeup ${LDFLAGS}"${EXTRA_LDFLAGS} -X k8s.io/kops.Version=${VERSION} -X k8s.io/kops.GitVersion=${GITSHA}" k8s.io/kops/cmd/nodeup
214217

215218
.PHONY: nodeup
216219
nodeup: nodeup-amd64
@@ -295,7 +298,7 @@ push-aws-run-amd64 push-aws-run-arm64: push-aws-run-%: push-%
295298

296299
.PHONY: ${NODEUP}
297300
${NODEUP}:
298-
go build ${GCFLAGS} ${BUILDFLAGS} ${EXTRA_BUILDFLAGS} ${LDFLAGS}"${EXTRA_LDFLAGS} -X k8s.io/kops.Version=${VERSION} -X k8s.io/kops.GitVersion=${GITSHA}" -o $@ k8s.io/kops/cmd/nodeup
301+
go build ${GCFLAGS} ${NODEUP_GCFLAGS} ${BUILDFLAGS} ${EXTRA_BUILDFLAGS} ${LDFLAGS}"${EXTRA_LDFLAGS} -X k8s.io/kops.Version=${VERSION} -X k8s.io/kops.GitVersion=${GITSHA}" -o $@ k8s.io/kops/cmd/nodeup
299302

300303
.PHONY: dns-controller-push
301304
dns-controller-push: ko-dns-controller-push

0 commit comments

Comments
 (0)