Skip to content

Commit 1d36e0c

Browse files
authored
Merge pull request #18263 from hakman/strip-nodeup
build: strip release binaries by default
2 parents a0731a5 + fa697fa commit 1d36e0c

1 file changed

Lines changed: 4 additions & 9 deletions

File tree

Makefile

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -81,23 +81,18 @@ DISCOVERY_SERVER_TAG=$(IMAGE_TAG)
8181

8282
CGO_ENABLED=0
8383
export CGO_ENABLED
84-
BUILDFLAGS="-trimpath"
84+
BUILDFLAGS=-trimpath -buildvcs=false
8585

8686

8787
# Go exports:
8888
LDFLAGS := -ldflags=all=
89-
90-
ifdef STATIC_BUILD
91-
CGO_ENABLED=0
92-
export CGO_ENABLED
93-
EXTRA_BUILDFLAGS=-installsuffix cgo
94-
EXTRA_LDFLAGS=-s -w
95-
endif
89+
EXTRA_LDFLAGS?=-s -w
9690

9791

9892
# Set compiler flags to allow binary debugging
9993
ifdef DEBUGGABLE
10094
GCFLAGS=-gcflags "all=-N -l"
95+
EXTRA_LDFLAGS=
10196
endif
10297

10398
.PHONY: kops-install # Install kops to local $GOPATH/bin
@@ -300,7 +295,7 @@ push-aws-run-amd64 push-aws-run-arm64: push-aws-run-%: push-%
300295

301296
.PHONY: ${NODEUP}
302297
${NODEUP}:
303-
go build ${GCFLAGS} ${EXTRA_BUILDFLAGS} ${LDFLAGS}"${EXTRA_LDFLAGS} -X k8s.io/kops.Version=${VERSION} -X k8s.io/kops.GitVersion=${GITSHA}" -o $@ k8s.io/kops/cmd/nodeup
298+
go build ${GCFLAGS} ${BUILDFLAGS} ${EXTRA_BUILDFLAGS} ${LDFLAGS}"${EXTRA_LDFLAGS} -X k8s.io/kops.Version=${VERSION} -X k8s.io/kops.GitVersion=${GITSHA}" -o $@ k8s.io/kops/cmd/nodeup
304299

305300
.PHONY: dns-controller-push
306301
dns-controller-push: ko-dns-controller-push

0 commit comments

Comments
 (0)