feat: introduce MaterialHandle and zCMaterialManager#406
Open
kirides wants to merge 10 commits into
Open
Conversation
Owner
Author
|
@Krystian12421 do you want to take a look at this? After your cleanup of the resources. This PR allows actually tracking the lifetime and count of zCMaterial* instances and ensures out-of-date handles never reach the rendering part |
I can test it tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaterialHandlerepresents a generationally tracked index into a flat zCMaterial* vector.zCMaterialManagerholds and validates any Handles.MeshKeyusesMaterialHandleto ensure any left-over and overriden zCMaterial* with the same pointer but different value are ignored.instead we just grab the fresh NearPlane of any zCCamera that gets created and store that and provide it to the engine.