Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions markdown/josh.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Intro

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice formatted intro here! Can you rename this file from josh.md to joshsagartz.md so that if there happens to be a user with the username josh, they can contribute their username.md?


This is josh. And this is a new file.
1 change: 1 addition & 0 deletions markdown/python scripts/main.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
print('Hello World!')

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello World! Couple edits here.

  1. Can you move the python scripts folder to the root of the project and then rename it to python-scripts?
  2. To avoid conflicts with others who might be simultaneously updating main.py, could you rename your main.py to main-joshsagartz.py?

Empty file added markdown/r-scripts/index.R
Empty file.
1 change: 1 addition & 0 deletions markdown/sql/dump.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
SELECT * from table

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet command here. Similar to the python update, can you move the sql folder to the root of the project and then rename your dump.sql to dump-joshsagartz.sql?