adding markdown, python script, r script, sql dump for josh#21
Open
joshsagartz wants to merge 1 commit into
Open
adding markdown, python script, r script, sql dump for josh#21joshsagartz wants to merge 1 commit into
joshsagartz wants to merge 1 commit into
Conversation
kimpenguin
reviewed
Oct 26, 2021
| @@ -0,0 +1 @@ | |||
| print('Hello World!') No newline at end of file | |||
Owner
There was a problem hiding this comment.
Hello World! Couple edits here.
- Can you move the
python scriptsfolder to the root of the project and then rename it topython-scripts? - To avoid conflicts with others who might be simultaneously updating
main.py, could you rename yourmain.pytomain-joshsagartz.py?
kimpenguin
reviewed
Oct 26, 2021
| @@ -0,0 +1 @@ | |||
| SELECT * from table No newline at end of file | |||
Owner
There was a problem hiding this comment.
Sweet command here. Similar to the python update, can you move the sql folder to the root of the project and then rename your dump.sql to dump-joshsagartz.sql?
kimpenguin
reviewed
Oct 26, 2021
| @@ -0,0 +1,3 @@ | |||
| # Intro | |||
Owner
There was a problem hiding this comment.
Nice formatted intro here! Can you rename this file from josh.md to joshsagartz.md so that if there happens to be a user with the username josh, they can contribute their username.md?
kimpenguin
requested changes
Oct 26, 2021
kimpenguin
left a comment
kimpenguin
left a comment
Owner
There was a problem hiding this comment.
Thanks so much for contributing @joshsagartz! A couple comments to address here before I can approve the pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.