Skip to content

fix: deps and ci hardening #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kacy merged 1 commit into from
Feb 27, 2026
Merged

fix: deps and ci hardening #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,22 @@ jobs:
- name: build
run: docker build -t ember:ci .

go-client:
name: go client
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
cache-dependency-path: clients/ember-go/go.sum
- name: build
working-directory: clients/ember-go
run: go build ./...
- name: test
working-directory: clients/ember-go
run: go test ./...

security:
name: security
runs-on: ubuntu-latest
Expand Down
8 changes: 6 additions & 2 deletions clients/ember-py/ember/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,12 +289,14 @@ def vadd(
"euclidean": ember_pb2.VECTOR_METRIC_EUCLIDEAN,
"ip": ember_pb2.VECTOR_METRIC_INNER_PRODUCT,
}
if metric not in metric_map:
raise ValueError(f"unknown metric {metric!r}; expected one of: cosine, euclidean, ip")
resp = self._stub.VAdd(
ember_pb2.VAddRequest(
key=key,
element=element,
vector=vector,
metric=metric_map.get(metric, ember_pb2.VECTOR_METRIC_COSINE),
metric=metric_map[metric],
connectivity=m,
ef_construction=ef,
),
Expand All @@ -320,6 +322,8 @@ def vadd_batch(
"euclidean": ember_pb2.VECTOR_METRIC_EUCLIDEAN,
"ip": ember_pb2.VECTOR_METRIC_INNER_PRODUCT,
}
if metric not in metric_map:
raise ValueError(f"unknown metric {metric!r}; expected one of: cosine, euclidean, ip")
batch_entries = [
ember_pb2.VAddBatchEntry(element=elem, vector=vec)
for elem, vec in entries
Expand All @@ -328,7 +332,7 @@ def vadd_batch(
ember_pb2.VAddBatchRequest(
key=key,
entries=batch_entries,
metric=metric_map.get(metric, ember_pb2.VECTOR_METRIC_COSINE),
metric=metric_map[metric],
connectivity=m,
ef_construction=ef,
),
Expand Down
Loading