fix: deps and ci hardening - #327
Merged
Merged
Conversation
- clients/ember-py: vadd and vadd_batch now raise ValueError for unrecognized metric strings instead of silently falling back to cosine — catches typos at call time (M4) - .github/workflows/ci.yml: add go-client job that builds and tests clients/ember-go on every push/pr (L1)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
closes out the final items from the security/reliability audit:
ValueErrorfor unrecognized vector metric strings (vadd,vadd_batch). previously a typo like"cosinee"silently used cosine, giving wrong results with no indication.bytes = "1.11.1"in lock file (≥ 1.5.1 required by CVE-2024-38368). no action needed.heapless 0.7.17andatomic-polyfill 1.0.3from the dep tree.cargo auditnow reports zero advisories.what was tested
cargo audit— zero advisories after postcard changebyteslock file entry is 1.11.1.get()default)