Skip to content

fix: add --no-grpc to benchmarks that don't need grpc #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kacy merged 1 commit into from
Feb 16, 2026
Merged

fix: add --no-grpc to benchmarks that don't need grpc #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bench/bench-encryption.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@ KEY_FILE=$(mktemp)
dd if=/dev/urandom bs=32 count=1 2>/dev/null > "$KEY_FILE"

echo "starting plaintext server on port $PLAINTEXT_PORT..."
$EMBER_BIN --port "$PLAINTEXT_PORT" --data-dir "$TMPDIR_PLAIN" --appendonly > /dev/null 2>&1 &
$EMBER_BIN --port "$PLAINTEXT_PORT" --data-dir "$TMPDIR_PLAIN" --appendonly --no-grpc > /dev/null 2>&1 &
PLAINTEXT_PID=$!
wait_for_server "$PLAINTEXT_PORT" "ember (plaintext)"

echo "starting encrypted server on port $ENCRYPTED_PORT..."
$EMBER_BIN --port "$ENCRYPTED_PORT" --data-dir "$TMPDIR_ENC" --appendonly --encryption-key-file "$KEY_FILE" > /dev/null 2>&1 &
$EMBER_BIN --port "$ENCRYPTED_PORT" --data-dir "$TMPDIR_ENC" --appendonly --encryption-key-file "$KEY_FILE" --no-grpc > /dev/null 2>&1 &
ENCRYPTED_PID=$!
wait_for_server "$ENCRYPTED_PORT" "ember (encrypted)"

Expand Down
10 changes: 5 additions & 5 deletions bench/bench-memory.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ TYPE_LABELS+=("string (${VALUE_SIZE}B)")

# ember concurrent
echo " starting ember concurrent..."
$EMBER_BIN --port $EMBER_CONCURRENT_PORT --concurrent > /dev/null 2>&1 &
$EMBER_BIN --port $EMBER_CONCURRENT_PORT --concurrent --no-grpc > /dev/null 2>&1 &
EC_PID=$!
wait_for_server $EMBER_CONCURRENT_PORT

Expand All @@ -198,7 +198,7 @@ sleep 0.5

# ember sharded
echo " starting ember sharded..."
$EMBER_BIN --port $EMBER_SHARDED_PORT > /dev/null 2>&1 &
$EMBER_BIN --port $EMBER_SHARDED_PORT --no-grpc > /dev/null 2>&1 &
ES_PID=$!
wait_for_server $EMBER_SHARDED_PORT

Expand Down Expand Up @@ -236,7 +236,7 @@ TYPE_LABELS+=("hash (5 fields)")
EMBER_CONCURRENT_BYTES+=("—")

echo " starting ember sharded..."
$EMBER_BIN --port $EMBER_SHARDED_PORT > /dev/null 2>&1 &
$EMBER_BIN --port $EMBER_SHARDED_PORT --no-grpc > /dev/null 2>&1 &
ES_PID=$!
wait_for_server $EMBER_SHARDED_PORT

Expand Down Expand Up @@ -272,7 +272,7 @@ TYPE_LABELS+=("sorted set")
EMBER_CONCURRENT_BYTES+=("—")

echo " starting ember sharded..."
$EMBER_BIN --port $EMBER_SHARDED_PORT > /dev/null 2>&1 &
$EMBER_BIN --port $EMBER_SHARDED_PORT --no-grpc > /dev/null 2>&1 &
ES_PID=$!
wait_for_server $EMBER_SHARDED_PORT

Expand Down Expand Up @@ -342,7 +342,7 @@ PYEOF

# vector requires sharded mode
echo " starting ember sharded..."
$EMBER_BIN --port $EMBER_SHARDED_PORT > /dev/null 2>&1 &
$EMBER_BIN --port $EMBER_SHARDED_PORT --no-grpc > /dev/null 2>&1 &
VEC_PID=$!
wait_for_server $EMBER_SHARDED_PORT

Expand Down
4 changes: 2 additions & 2 deletions bench/bench-memtier.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,13 +324,13 @@ declare -a D_P99=()

# ember concurrent
start_server "ember concurrent" "$EMBER_CONCURRENT_PORT" \
"$EMBER_BIN" --port "$EMBER_CONCURRENT_PORT" --concurrent
"$EMBER_BIN" --port "$EMBER_CONCURRENT_PORT" --concurrent --no-grpc
run_server_tests "$EMBER_CONCURRENT_PORT" "ember concurrent" EC_OPS EC_P99
stop_server

# ember sharded
start_server "ember sharded" "$EMBER_SHARDED_PORT" \
"$EMBER_BIN" --port "$EMBER_SHARDED_PORT"
"$EMBER_BIN" --port "$EMBER_SHARDED_PORT" --no-grpc
run_server_tests "$EMBER_SHARDED_PORT" "ember sharded" ES_OPS ES_P99
stop_server

Expand Down
4 changes: 2 additions & 2 deletions bench/bench.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ fi
cleanup

echo "starting servers..."
$EMBER_BIN --port $EMBER_SHARDED_PORT > /dev/null 2>&1 &
$EMBER_BIN --port $EMBER_CONCURRENT_PORT --concurrent > /dev/null 2>&1 &
$EMBER_BIN --port $EMBER_SHARDED_PORT --no-grpc > /dev/null 2>&1 &
$EMBER_BIN --port $EMBER_CONCURRENT_PORT --concurrent --no-grpc > /dev/null 2>&1 &
redis-server --port $REDIS_PORT --daemonize yes --save "" --appendonly no > /dev/null 2>&1
sleep 2

Expand Down
5 changes: 3 additions & 2 deletions bench/compare-redis.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,14 +165,15 @@ echo "threads: $THREADS"
echo ""

# ember concurrent mode (DashMap-backed, fastest for GET/SET)
# --no-grpc avoids gRPC port conflict when running multiple instances
echo "starting ember concurrent on port $EMBER_CONCURRENT_PORT..."
"$EMBER_BIN" --port "$EMBER_CONCURRENT_PORT" --concurrent > /dev/null 2>&1 &
"$EMBER_BIN" --port "$EMBER_CONCURRENT_PORT" --concurrent --no-grpc > /dev/null 2>&1 &
EMBER_CONCURRENT_PID=$!
wait_for_server "$EMBER_CONCURRENT_PORT" "ember-concurrent"

# ember sharded mode (channel-based, supports all data types)
echo "starting ember sharded ($CPU_CORES shards) on port $EMBER_SHARDED_PORT..."
"$EMBER_BIN" --port "$EMBER_SHARDED_PORT" > /dev/null 2>&1 &
"$EMBER_BIN" --port "$EMBER_SHARDED_PORT" --no-grpc > /dev/null 2>&1 &
EMBER_SHARDED_PID=$!
wait_for_server "$EMBER_SHARDED_PORT" "ember-sharded"

Expand Down