fix: add --no-grpc to benchmarks that don't need grpc - #159
Merged
Conversation
the default gRPC port (6380) conflicts when multiple ember instances run simultaneously. compare-redis.sh starts concurrent on 6379 and sharded on 6380, but concurrent's gRPC listener already holds 6380. similarly for bench.sh and bench-encryption.sh. since these benchmarks measure RESP3 throughput (not gRPC), --no-grpc is the cleanest fix. bench-grpc.sh is the only script that needs gRPC and it already sets --grpc-port explicitly.
kacy
added a commit
that referenced
this pull request
Feb 19, 2026
the default gRPC port (6380) conflicts when multiple ember instances run simultaneously. compare-redis.sh starts concurrent on 6379 and sharded on 6380, but concurrent's gRPC listener already holds 6380. similarly for bench.sh and bench-encryption.sh. since these benchmarks measure RESP3 throughput (not gRPC), --no-grpc is the cleanest fix. bench-grpc.sh is the only script that needs gRPC and it already sets --grpc-port explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
ember's default gRPC port (6380) causes conflicts when multiple instances run simultaneously. the gRPC listener binds to 6380 regardless of the RESP3 port, so:
since these benchmarks measure RESP3 throughput, adding
--no-grpcis the correct fix. bench-grpc.sh is the only script that needs gRPC and already sets--grpc-portexplicitly.what was tested
--no-grpcflag disables the gRPC listener