Skip to content

HubClient: retry transient Hub tree-listing failures (429/5xx) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AurionRodgerDiablo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

HubClient: retry transient Hub tree-listing failures (429/5xx) #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions Sources/CoreAIKitCore/HubClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,28 @@ struct HubClient: Sendable {
else {
throw CoreAIKitError.variantNotFound(repo: repo, path: path, revision: revision)
}
let (data, resp) = try await URLSession.shared.data(from: api)
guard (resp as? HTTPURLResponse)?.statusCode == 200 else {
throw CoreAIKitError.variantNotFound(repo: repo, path: path, revision: revision)
// The Hub API sheds load with transient 429s ("maximum queue size reached") and
// occasional 5xx; retry those with backoff — only a firm 4xx means the subtree
// really isn't published.
var data = Data()
var status = 0
for attempt in 0..<5 {
if attempt > 0 {
try await Task.sleep(nanoseconds: UInt64(1 << attempt) * 1_000_000_000)
}
Comment on lines +41 to +43
try Task.checkCancellation()
let (d, resp) = try await URLSession.shared.data(from: api)
status = (resp as? HTTPURLResponse)?.statusCode ?? 0
if status == 200 {
data = d
break
}
if (400..<500).contains(status), status != 429 {
throw CoreAIKitError.variantNotFound(repo: repo, path: path, revision: revision)
}
}
guard status == 200 else {
throw CoreAIKitError.httpError(statusCode: status, file: api.absoluteString)
}
Comment on lines +55 to 57

struct TreeEntry: Decodable {
Expand Down