Skip to content

images with relative paths can be displayed properly. #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tang895 wants to merge 2 commits into from
Closed

images with relative paths can be displayed properly. #1562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6294926
Comment out HtmlPostProcessor.clean calls
Tang895 Nov 6, 2025
2092683
Add base URL for loading images in WebView
Tang895 Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/src/main/java/com/capyreader/app/ui/components/WebView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,14 @@ class WebViewState(
byline = article.byline(context = webView.context),
colors = colors
)
//Pass in the base URL so that images with relative paths can be displayed properly.
val baseUrl = article.url.toString()?.let { url ->
val index = url.lastIndexOf('/') + 1
url.substring(0, index)
} ?: article.siteURL

webView.loadDataWithBaseURL(
null,
baseUrl,
html,
null,
"UTF-8",
Expand Down
8 changes: 4 additions & 4 deletions capy/src/main/java/com/jocmp/capy/articles/ArticleRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ class ArticleRenderer(
} else {
article.siteURL?.let { document.setBaseUri(it) }
}

HtmlPostProcessor.clean(contentHTML, hideImages = hideImages)
//do not clean, when website use images of relative path, this code will clean wrongly
//HtmlPostProcessor.clean(contentHTML, hideImages = hideImages)

document.content?.append(
parseHtml(
Expand All @@ -89,8 +89,8 @@ class ArticleRenderer(
}

document.content?.append(article.content)

HtmlPostProcessor.clean(document, hideImages = hideImages)
//do not clean, when website use images of relative path, this code will clean wrongly
//HtmlPostProcessor.clean(document, hideImages = hideImages)
}

return document.html()
Expand Down