images with relative paths can be displayed properly.#1562
Closed
Tang895 wants to merge 2 commits into
Closed
Conversation
Commented out HtmlPostProcessor.clean calls to prevent incorrect cleaning of documents with relative image paths.
Pass in the base URL to load images with relative paths.
Owner
|
Hey @Tang895, thanks for taking the time to look into this. From what I remember, the base URL will sometimes prevent images from loading if it's present due to some cross-site rules. I had addressed this previously with the following PR with an allowed list of sites. I don't remember why I ripped it out: tl;dr I think this might be a case-by-case fix. Are there certain websites you notice this breaks on? |
Author
|
Thank you for your reply. I didn’t take cross-site access into consideration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass in the base URL so that images with relative paths can be displayed properly.
comment two "HtmlPostProcessor.clean(contentHTML, hideImages = hideImages)"